Closed Bug 1377599 Opened 4 years ago Closed 4 years ago

browser_bookmark_popup.js fails with async places transactions turned on

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1377599 - Fix typos to make the Star UI remove bookmarks correctly, and add an extra hook to ensure the tests passes in async mode.
59 bytes, text/x-review-board-request
mak
: review+
Details 
This test fails when browser.places.useAsyncTransactions is set to true:

23:03:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Page is starred after closing - Got true, expected false
2347 23:03:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | bookmark should not be present if a panel action should've removed it - Got true, expected false
2361 23:03:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Page is starred after closing - Got true, expected false
2366 23:03:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | bookmark should not be present if a panel action should've removed it - Got true, expected false
2380 23:03:41 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Page is starred after closing - Got true, expected false
2385 23:03:41 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | bookmark should not be present if a panel action should've removed it - Got true, expected false
2406 23:03:43 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Page is starred after closing - Got true, expected false
2411 23:03:43 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | bookmark should not be present if a panel action should've removed it - Got true, expected false
Depends on: 1371677
I've found the issue here as well - there's some mistakes in the Star UI for bookmark removal, and the test needs to wait for the bookmark remove notification.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Comment on attachment 8885790 [details]
Bug 1377599 - Fix typos to make the Star UI remove bookmarks correctly, and add an extra hook to ensure the tests passes in async mode.

https://reviewboard.mozilla.org/r/156580/#review161666

I assume you are checking these on Try, I can't tell if other tests may me unhappy off-hand. Good work and good catch on the PlacesUtils typo!
Attachment #8885790 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/813550f3f713
Fix typos to make the Star UI remove bookmarks correctly, and add an extra hook to ensure the tests passes in async mode. r=mak
https://hg.mozilla.org/mozilla-central/rev/813550f3f713
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.