|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
> In file included from /home/worker/workspace/build/src/js/src/vtune/ittnotify_static.c:75:0: > /home/worker/workspace/build/src/js/src/vtune/ittnotify.h:1831:19: error: '__itt_null' is static but used in inline function '__itt_id_make' which is not static [-Werror] > __itt_id id = __itt_null; This misuse breaks the mingw build. Because this is in a third party library I suspect that we have no chance of upstreaming a fix in, I'm wondering if the best course of action is to disable -Werror on this file...
We have already made a few small changes to VTune. When making those changes, to make sure that they persist across VTune upgrades, we've elected to simply describe the modification to be made in js/src/vtune/README. So it's OK to just make a fix and link to this bug there.
Comment on attachment 8882780 [details] Bug 1377651 Make vtune variable non-static so it may be used in a non-static function https://reviewboard.mozilla.org/r/153888/#review159608
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/829264977c95 Make vtune variable non-static so it may be used in a non-static function r=sstangl