Static variable used in non-static function causes error in vtune

RESOLVED FIXED in Firefox 56

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

(Blocks: 1 bug)

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [tor])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
> In file included from /home/worker/workspace/build/src/js/src/vtune/ittnotify_static.c:75:0:
> /home/worker/workspace/build/src/js/src/vtune/ittnotify.h:1831:19: error: '__itt_null' is static but used in inline function '__itt_id_make' which is not static [-Werror]
>      __itt_id id = __itt_null;

This misuse breaks the mingw build.

Because this is in a third party library I suspect that we have no chance of upstreaming a fix in, I'm wondering if the best course of action is to disable -Werror on this file...
Comment hidden (mozreview-request)

Updated

5 months ago
Blocks: 1332466
We have already made a few small changes to VTune.

When making those changes, to make sure that they persist across VTune upgrades, we've elected to simply describe the modification to be made in js/src/vtune/README. So it's OK to just make a fix and link to this bug there.
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Attachment #8882780 - Flags: review?(sstangl)

Comment 4

5 months ago
mozreview-review
Comment on attachment 8882780 [details]
Bug 1377651 Make vtune variable non-static so it may be used in a non-static function

https://reviewboard.mozilla.org/r/153888/#review159608
Attachment #8882780 - Flags: review?(sstangl) → review+
(Assignee)

Updated

5 months ago
Keywords: checkin-needed

Comment 5

5 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/829264977c95
Make vtune variable non-static so it may be used in a non-static function r=sstangl
Keywords: checkin-needed

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/829264977c95
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.