Closed
Bug 1377740
Opened 7 years ago
Closed 7 years ago
Clicking on some links in about:firefox doesn't do anything
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(fennec+, firefox54 unaffected, firefox55 unaffected, firefox56+ verified)
VERIFIED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
fennec | + | --- |
firefox54 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | + | verified |
People
(Reporter: gvanwaelvelde, Assigned: Sylvestre, Mentored)
Details
(Keywords: regression)
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; rv:54.0) Gecko/20100101 Firefox/54.0 Build ID: 20170628075643 Steps to reproduce: My device is a Samsung J7 running Android 6.0.1, Firefox 56.0a1 (2017-07-01). 1) Navigate to about:firefox 2) Click on "FAQ", "Support", "Privacy Policy" or "Credits" Actual results: Nothing happens. Clicking on "Licensing Information" or "Know Your Rights" works. Expected results: Redirection to relevant webpage.
Comment 1•7 years ago
|
||
[Tracking Requested - why for this release]: regression in default bookmark about:firefox. This is a blocker to releasing Firefox for Android v56
Status: UNCONFIRMED → NEW
tracking-fennec: --- → ?
Has STR: --- → yes
status-firefox54:
--- → unaffected
status-firefox55:
--- → unaffected
status-firefox56:
--- → affected
tracking-firefox56:
--- → ?
Ever confirmed: true
Keywords: regression,
regressionwindow-wanted
Comment 2•7 years ago
|
||
Regression window performed: Last good revision: 5293e5f8935831e2e0d91ac9b69c1b473b3c0177 (2017-06-13) First bad revision: b266a8d8fd595b84a7d6218d7b8c6b7af0b5027c (2017-06-14)
Keywords: regressionwindow-wanted
Comment 3•7 years ago
|
||
Providing the tree that was bisected (autoland/mozilla-inbound/mozilla-central) and the link to the change set range is helpful. A ton of work is in that one day range. https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5293e5f8935831e2e0d91ac9b69c1b473b3c0177&tochange=b266a8d8fd595b84a7d6218d7b8c6b7af0b5027c This needs to be bisected using inbound/autoland builds.
Keywords: regressionwindow-wanted
Updated•7 years ago
|
Comment 4•7 years ago
|
||
Hi Dao Could you give me some advice if this may related to previous about pages work? Thank you!
Flags: needinfo?(dao+bmo)
Updated•7 years ago
|
Assignee: nobody → cnevinchen
Priority: -- → P1
Comment 5•7 years ago
|
||
(In reply to Nevin Chen [:nechen] from comment #4) > Hi Dao > Could you give me some advice if this may related to previous about pages > work? > > Thank you! If you mean the styling work for about:rights for instance, then no, this seems unrelated to that.
Flags: needinfo?(dao+bmo)
Updated•7 years ago
|
tracking-fennec: ? → +
Comment 6•7 years ago
|
||
Hi sylvestre Could you please check if your patch causes this bug? Cause I see in comment 3 your fix in Bug 1372215 has modified mobile/android/chrome/content/about.xhtml Thank you!
Flags: needinfo?(sledru)
Assignee | ||
Comment 7•7 years ago
|
||
This is very unlikely, my patch just hides a link see the patch here: https://hg.mozilla.org/mozilla-central/rev/5c0b6ba1da06
Flags: needinfo?(sledru)
Comment 8•7 years ago
|
||
After I remove your fix and build again, the links could be clicked normally. Could you please help try verify again?
Flags: needinfo?(sledru)
Comment 9•7 years ago
|
||
I guess you will have problem with your fix in here http://searchfox.org/mozilla-central/source/mobile/android/chrome/content/about.js#56 cause releaseNotesURL is not found
Comment 10•7 years ago
|
||
This is just a small fix. If anyone want to take it, feel free to do it. Just add a null check in comment 9. If no one want to do it. I'll fix it before 56.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•7 years ago
|
||
My bad, I took it as I am the one who introduced it. FYI, this is only happening with nightly.
Assignee: cnevinchen → sledru
Flags: needinfo?(sledru)
Keywords: good-first-bug,
regressionwindow-wanted
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8889283 [details] Bug 1377740 - Only set the url when the link exists n?nechen https://reviewboard.mozilla.org/r/160332/#review165618 Thanks!
Attachment #8889283 -
Flags: review+
Comment 14•7 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/059f64f6bc23 Only set the url when the link exists n?nechen r=nechen
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/059f64f6bc23
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•7 years ago
|
Flags: needinfo?(cnevinchen)
Comment 16•7 years ago
|
||
Verified as fixed on Nightly 56 (2017-07-25). Device: LG G4 (Android 5.1).
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•