Closed Bug 1377740 Opened 2 years ago Closed 2 years ago
Clicking on some links in about:firefox doesn't do anything
59 bytes, text/x-review-board-request
[Tracking Requested - why for this release]: regression in default bookmark about:firefox. This is a blocker to releasing Firefox for Android v56
Regression window performed: Last good revision: 5293e5f8935831e2e0d91ac9b69c1b473b3c0177 (2017-06-13) First bad revision: b266a8d8fd595b84a7d6218d7b8c6b7af0b5027c (2017-06-14)
Providing the tree that was bisected (autoland/mozilla-inbound/mozilla-central) and the link to the change set range is helpful. A ton of work is in that one day range. https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5293e5f8935831e2e0d91ac9b69c1b473b3c0177&tochange=b266a8d8fd595b84a7d6218d7b8c6b7af0b5027c This needs to be bisected using inbound/autoland builds.
Hi Dao Could you give me some advice if this may related to previous about pages work? Thank you!
Assignee: nobody → cnevinchen
Priority: -- → P1
(In reply to Nevin Chen [:nechen] from comment #4) > Hi Dao > Could you give me some advice if this may related to previous about pages > work? > > Thank you! If you mean the styling work for about:rights for instance, then no, this seems unrelated to that.
Hi sylvestre Could you please check if your patch causes this bug? Cause I see in comment 3 your fix in Bug 1372215 has modified mobile/android/chrome/content/about.xhtml Thank you!
This is very unlikely, my patch just hides a link see the patch here: https://hg.mozilla.org/mozilla-central/rev/5c0b6ba1da06
After I remove your fix and build again, the links could be clicked normally. Could you please help try verify again?
I guess you will have problem with your fix in here http://searchfox.org/mozilla-central/source/mobile/android/chrome/content/about.js#56 cause releaseNotesURL is not found
This is just a small fix. If anyone want to take it, feel free to do it. Just add a null check in comment 9. If no one want to do it. I'll fix it before 56.
My bad, I took it as I am the one who introduced it. FYI, this is only happening with nightly.
Comment on attachment 8889283 [details] Bug 1377740 - Only set the url when the link exists n?nechen https://reviewboard.mozilla.org/r/160332/#review165618 Thanks!
Attachment #8889283 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/059f64f6bc23 Only set the url when the link exists n?nechen r=nechen
Verified as fixed on Nightly 56 (2017-07-25). Device: LG G4 (Android 5.1).
You need to log in before you can comment on or make changes to this bug.