TelemetrySession.jsm uses non-existing API Services.tm.mainThread.idleDispatch

RESOLVED FIXED in Firefox 56

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ato, Assigned: erahm)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

2 years ago
This is occasionally logged when running Firefox:

> JavaScript error: resource://gre/modules/TelemetrySession.jsm, line 1979: TypeError: Services.tm.mainThread.idleDispatch is not a function

The Services.tm.mainThread.idleDispatch API was renamed in https://bugzilla.mozilla.org/show_bug.cgi?id=1368072 to Services.tm.idleDispatchToMainThread.
Reporter

Updated

2 years ago
Depends on: 1340134
Comment hidden (mozreview-request)
Reporter

Updated

2 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee

Comment 2

2 years ago
mozreview-review
Comment on attachment 8882896 [details]
Bug 1377767 - Fix idle dispatch call to gather memory in Telemetry;

https://reviewboard.mozilla.org/r/153922/#review159148

Thanks for catching this!
Attachment #8882896 - Flags: review?(erahm) → review+
Priority: -- → P3
I see this a lot lately in our test results for failing tests. Given that Andreas is out the next days and the patch got review+ lets get this landed.

Comment 4

2 years ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0650bad015bc
Fix idle dispatch call to gather memory in Telemetry; r=erahm

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0650bad015bc
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee

Comment 6

2 years ago
Currently the cached count is only updated if a table was passed in to keep
track of the window IDs. This changes the behavior to always update the count
regardless of whether a table is passed in.

MozReview-Commit-ID: EkfzLemVJyV
Attachment #8891104 - Flags: review?(continuation)
Assignee

Updated

2 years ago
Assignee: ato → erahm
Assignee

Comment 7

2 years ago
Comment on attachment 8891104 [details] [diff] [review]
Always update cached ghost window count

Sorry wrong bug number.
Attachment #8891104 - Attachment is obsolete: true
Attachment #8891104 - Flags: review?(continuation)
You need to log in before you can comment on or make changes to this bug.