1377767 - TelemetrySession.jsm uses non-existing API Services.tm.mainThread.idleDispatch

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Andreas Tolfsen ❲:ato❳]

This is occasionally logged when running Firefox:

> JavaScript error: resource://gre/modules/TelemetrySession.jsm, line 1979: TypeError: Services.tm.mainThread.idleDispatch is not a function

The Services.tm.mainThread.idleDispatch API was renamed in https://bugzilla.mozilla.org/show_bug.cgi?id=1368072 to Services.tm.idleDispatchToMainThread.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1377767 - Fix idle dispatch call to gather memory in Telemetry;

The Services.tm.mainThread.idleDispatch API was renamed in
https://bugzilla.mozilla.org/show_bug.cgi?id=1368072 to
Services.tm.idleDispatchToMainThread.

Review commit: https://reviewboard.mozilla.org/r/153922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153922/

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8882896 [details]
Bug 1377767 - Fix idle dispatch call to gather memory in Telemetry;

https://reviewboard.mozilla.org/r/153922/#review159148

Thanks for catching this!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I see this a lot lately in our test results for failing tests. Given that Andreas is out the next days and the patch got review+ lets get this landed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0650bad015bc
Fix idle dispatch call to gather memory in Telemetry; r=erahm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0650bad015bc

Comment 6

[Eric Rahm [:erahm]]

Attachment: Always update cached ghost window count

Currently the cached count is only updated if a table was passed in to keep
track of the window IDs. This changes the behavior to always update the count
regardless of whether a table is passed in.

MozReview-Commit-ID: EkfzLemVJyV

Comment 7

[Eric Rahm [:erahm]]

Comment on attachment 8891104 [details] [diff] [review]
Always update cached ghost window count

Sorry wrong bug number.