Firefox sends "tickle-wifi" UDP packets to 1.0.0.0 instead of default gateway

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: spam.mozilla.org, Assigned: spam.mozilla.org)

Tracking

Trunk
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.109 Safari/537.36

Steps to reproduce:

* Run tcpdump on my router to see packets sent to the internet (optionally limited to UDP packets on port 4886)

* Open any website in Firefox for Android (while connected via aforementioned router)



Actual results:

Lots of UDP packets are sent to 1.0.0.0:4886 (see screenshot), an address from the APNIC research prefix.




Expected results:

According to bug #888268, these packets should be sent to the default gateway, never leaving the LAN.

I suppose the underlying problem is as follows:
The default gateway's IP address is retrieved from dom/network/Connection.cpp, which casts the IP address from uint32_t to bool and back to uint32_t, therefore it has the value "1", which corresponds to the IP address 1.0.0.0.
(Assignee)

Comment 1

2 years ago
Comment on attachment 8882926 [details] [diff] [review]
fixDhcpGateway.patch

Snorp please have a look at this patch or send it to a reviewer that can review it.
Attachment #8882926 - Flags: review?(snorp)
Comment on attachment 8882926 [details] [diff] [review]
fixDhcpGateway.patch

Review of attachment 8882926 [details] [diff] [review]:
-----------------------------------------------------------------

Wow! Nice catch!
Attachment #8882926 - Flags: review?(snorp) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed
Assignee: nobody → spam.mozilla.org

Comment 4

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/207dd6b9d716
Fix setting of default gateway's IP address. r=snorp
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/207dd6b9d716
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.