1377840 - Change return code for TM requests exceeding 255 bytes

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P5)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

STR:
1) Go to https://mozilla-pontoon-staging.herokuapp.com/cs/amo/all-resources/?status=missing&string=166657
2) Open network tab.
3) Refresh.

You will see 400 bad request to /translation-memory/ for translation memory. This string is pretty rich on tags and quite long, so that may be the cause.

Comment 1

[Matjaz Horvat [:mathjazz]]

The filter doesn't show any strings. If the string is longer than 255 characters, TM returns 400 due to Postgres levenshtein limitations.

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Sorry, I was playing to reproduce the other bug with bulk actions. Now you will see the string.

That will be probably the case. Anyway 400 return code is for client error, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.1, but this is know state and an issue on the server side.

Comment 3

[Matjaz Horvat [:mathjazz]]

OK, maybe we could use 501 instead and detect too long requests on the client side already.

But I'd prefer if we instead focused on finding a solution to support all TM requests, regardless of their length.

Comment 4

[Nathaniel Nebel (:nnebel)]

Hello I would be interested in potentially tackling this bug, is it still available? Would mentoring also be available for this issue?

Comment 5

[Matjaz Horvat [:mathjazz]]

Nathaniel, this bug is already taken and Hadi needs to assign it to himself:
https://github.com/mozilla/pontoon/pull/729/

Please ping me in #pontoon or privately via email if you're looking for a bug to take.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/b5ed449f9cc435782214bbc85f4e885588a1cd90
Fix bug 1377840: Update long TM request error code (#729)

Update return code of TM requests exceeding 255 bytes