"Do not disturb me" option still shows doorhanger offering to allow the website to show notifications

NEW
Unassigned

Status

()

Firefox
Preferences
P5
major
8 months ago
5 months ago

People

(Reporter: Virtual, Unassigned)

Tracking

({nightly-community})

Trunk
x86_64
Windows 7
nightly-community
Points:
---

Firefox Tracking Flags

(firefox56 affected)

Details

Attachments

(1 attachment)

1. Go to "Options" ( about:preferences )
2. Press "Privacy & Security" option ( about:preferences#privacy )
3. Enable "Do not disturb me"
3. Open one of these website pages:
- https://tests.peter.sh/notification-generator/
- http://www.polsatsport.pl/wiadomosc/2017-07-02/ms-u21-polska-kuba-relacja-i-wynik-na-zywo/
and see that notification is still shown in doorhanger/panelUI
Flags: needinfo?(jaws)
I am unable to reproduce this. I tested with both a Nightly build from 2016-01-01 and 2017-07-03. They both show the same behavior.

The doorhanger/panelUI is expected even with "Do Not Disturb" enabled. However when "Do Not Disturb" is enabled, and you click on the "Display the notification" button on https://tests.peter.sh/notification-generator/ then you shouldn't see a notification in the bottom right corner of your screen. With "Do Not Disturb" unchecked, clicking on the button will show the notification.
Flags: needinfo?(jaws) → needinfo?(Virtual)
Created attachment 8883105 [details]
screencast.mp4

This is what I'm seeing on stable Firefox 54 (Portable), see attachment in Comment #2.

Why enabling "Do not disturb me" doesn't also disable doorhanger/panelUI asking for
> "Will you allow "some website page" to send notifications?"
when I especially disabled notifications per
> "No notification will be shown until you restart Nightly"
which means I don't also want to see doorhanger/panelUI asking for my permissions again and again about any notifications.

Also it's a very bad idea for this setting to be set to default when restarting browser, as this could be done in other way mentioned in bottom or even in "Clear history when Nightly closes" in its "Settings".

Opera for example have these settings about Notifications
> Notifications
> - Allow all sites to show desktop notifications
> - Ask me when a site wants to show desktop notifications
> - Do not allow any site to show desktop notifications

Maybe we could also change it to be more logical.
Flags: needinfo?(Virtual)
Okay, yes this is what I saw in comment #1. "Do not disturb" is not fully broken as your original bug summary alluded to. We could probably hide the doorhanger when do-not-disturb is enabled, though it may not be possible for users to know that they are missing out on notifications otherwise.

Since it's fairly out of the way to enable "do not disturb" mode, I'm fine with not showing the doorhanger in this case.
Summary: "Do not disturb me" option doesn't work at all → "Do not disturb me" option still shows doorhanger offering to allow the website to show notifications
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> [...]
> it may not be possible for users to know that they are missing out on notifications otherwise.
> 
> Since it's fairly out of the way to enable "do not disturb" mode, I'm fine
> with not showing the doorhanger in this case.

If users will enable "Do not disturb me" feature, which is disabled by default, they will know they're missing notifications, as they enabled this feature especially for "No notification will be shown [...]", so they don't want to see: any notifications, any notifications about available notifications and any notifications about permissions about showing notifications, including any doorhanger/panelUI/popups/messages/warnings/errors/etc. ;)

I would be in favor to restyle this option like it's in Opera and like we have it in "Page Info" under "Permissions",
so:
> Receive Notifications
>   - Always Ask
>   - Allow
>   - Block
and we should make this setting permanent, not only for one Firefox run, as it's kinda inconsistent with other settings and kinda odd to use it that way.
I don't think "Do not disturb" is related to the doorhanger (and I don't think simply not showing the doorhanger without denying the permission request is an option because of web compat reasons). We might have to clarify the intent of that feature in the UI.

Bug 1313939 plans to add a global disable for permissions, that would also prevent showing the doorhanger. I would suggest closing this one as invalid/dupe.
You need to log in before you can comment on or make changes to this bug.