Update reftests to comply with new data: URI inheritance model

RESOLVED FIXED in Firefox 56

Status

()

P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

a year ago
Assignee: nobody → ckerschb
Blocks: 1324406
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
(Assignee)

Comment 1

a year ago
Created attachment 8883005 [details] [diff] [review]
bug_1377861_reftests.patch

Hey smaug, it seems file layout/reftests/bugs/381746-1.html had weired file ending, hence it seems I touched more files.
Attachment #8883005 - Flags: review?(bugs)
Attachment #8883005 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

a year ago
It seems that:
* reftest/tests/layout/reftests/bugs/212563-2.html
* reftest/tests/layout/reftests/bugs/381746-1.html
are not simply fixed by replacing src="data:..." with srcdoc="". I tried to debug but I couldn't really figure out where the exact problem is. My guess that somewhere the tests set the src attribute which is then ignored because we are using srcdoc to begin with and hence the test times out.

Since those two tests need more investigation and then also closer review I think the best path forward is to land the low hanging fruit within this bug and file follow ups for the two tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9213a20ef009f3cb9a4192b8064f5c4ab33053c

Comment 4

a year ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7529213e3375
Update reftests to comply with new data: URI inheritance model. r=smaug
Backed out for failing reftest iframe-border-radius.html on Windows 8 x64:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e22971fe3416a0cc7a39a55a5b7821502545823

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7529213e33752241cbc645f8d206c283959e074f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=112267026&repo=mozilla-inbound
> REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/scrolling/iframe-border-radius.html == file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/scrolling/iframe-border-radius-ref.html | image comparison, max difference: 1, number of differing pixels: 1
Flags: needinfo?(ckerschb)
(Assignee)

Comment 6

a year ago
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #5)
> Backed out for failing reftest iframe-border-radius.html on Windows 8 x64:

Works on other platforms but not Windows. I guess this needs more investigation. Similar to comment 3, let's land all the low hanging fruit within this bug and convert other tests that need more investigation (like in that case iframe-border-radius.html) in a different bug.
Flags: needinfo?(ckerschb)

Comment 7

a year ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/176faadcb01b
Update reftests to comply with new data: URI inheritance model. r=smaug

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/176faadcb01b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Assignee)

Updated

a year ago
See Also: → bug 1383732
(Assignee)

Updated

a year ago
See Also: → bug 1384048
You need to log in before you can comment on or make changes to this bug.