1377861 - Update reftests to comply with new data: URI inheritance model

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1377861_reftests.patch

Hey smaug, it seems file layout/reftests/bugs/381746-1.html had weired file ending, hence it seems I touched more files.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Let's make sure everything is fine before landing this one:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5873ef09ac6abe215d1cd0b658edff8a7d653107

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

It seems that:
* reftest/tests/layout/reftests/bugs/212563-2.html
* reftest/tests/layout/reftests/bugs/381746-1.html
are not simply fixed by replacing src="data:..." with srcdoc="". I tried to debug but I couldn't really figure out where the exact problem is. My guess that somewhere the tests set the src attribute which is then ignored because we are using srcdoc to begin with and hence the test times out.

Since those two tests need more investigation and then also closer review I think the best path forward is to land the low hanging fruit within this bug and file follow ups for the two tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9213a20ef009f3cb9a4192b8064f5c4ab33053c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7529213e3375
Update reftests to comply with new data: URI inheritance model. r=smaug

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing reftest iframe-border-radius.html on Windows 8 x64:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e22971fe3416a0cc7a39a55a5b7821502545823

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7529213e33752241cbc645f8d206c283959e074f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=112267026&repo=mozilla-inbound
> REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/scrolling/iframe-border-radius.html == file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/scrolling/iframe-border-radius-ref.html | image comparison, max difference: 1, number of differing pixels: 1

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #5)
> Backed out for failing reftest iframe-border-radius.html on Windows 8 x64:

Works on other platforms but not Windows. I guess this needs more investigation. Similar to comment 3, let's land all the low hanging fruit within this bug and convert other tests that need more investigation (like in that case iframe-border-radius.html) in a different bug.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/176faadcb01b
Update reftests to comply with new data: URI inheritance model. r=smaug

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/176faadcb01b