Closed Bug 1377869 Opened 3 years ago Closed 2 years ago

CompositorManagerChild::Init assert failure because PID reused

Categories

(Core :: Graphics, defect, P3)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

(Keywords: crash, Whiteboard: [gfx-noted])

Crash Data

Attachments

(1 file)

New crashes with a familiar signature:

https://crash-stats.mozilla.com/report/index/4947b15c-51a3-4932-be92-9a1be0170701
https://crash-stats.mozilla.com/report/index/fa3c8b8d-feae-44b8-8b86-8c6520170701

It looks like Windows can be fairly aggressive on reusing an old PID when it has gone out of scope:

https://blogs.msdn.microsoft.com/oldnewthing/20110107-00/?p=11803/

I think we need to remove/change this assert as such.
Blocks: 1365927
Keywords: crash
OS: Unspecified → Windows
Priority: -- → P3
Whiteboard: [gfx-noted]
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Crash Signature: [@ mozilla::layers::CompositorManagerChild::Init ]
Attachment #8886673 - Flags: review?(dvander) → review+
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf30d2b838f4
Ensure that CompositorManagerChild will be reinitialized if the GPU process reuses its PID. r=dvander
https://hg.mozilla.org/mozilla-central/rev/bf30d2b838f4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Still seeing the crash in the latest Nightly after this landed (e.g. bp-435e46da-05f1-4a49-80b0-549030170720). Any ideas?
Flags: needinfo?(aosmond)
I give up. Removing assert in bug 1382644.
Flags: needinfo?(aosmond)
You need to log in before you can comment on or make changes to this bug.