Closed Bug 1377929 Opened 4 years ago Closed 4 years ago

Remove button-hover-effect of composition's From: label, and fix focus indication

Categories

(Thunderbird :: Message Compose Window, defect)

33 Branch
All
Windows
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 56.0

People

(Reporter: thomas8, Assigned: Paenglab)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1112940 +++

(From Bug #1112940, comment 13 and comment 15)

STR

Monitor focus indication (dotted border) after each step.
A1 compose new msg by clicking Write button (important!)
B1 for comparison: compose new msg with keyboard shortcut Ctrl+N or Ctrl+M
2 click From: input field
3 click body, then click From: label
4 click body, then press Alt+r (or tab into from field).
5 repeat step 2 and 3

Actual result

If composition is started via button click (step A1), the focus indication is missing UNTIL step 4, alt+r keyboard shortcut to focus From field. After that (step 5), focus indication is always correct until composition is closed.

But if composition is started via Keyboard shortcut (step A2), the focus indication is always correct, right from the beginning, regardless of activation method (mouse vs. keyboard).

Expected result

When focused, From field must have dotted focus indicator, regardless if composition or from field was focused via mouse or keyboard.
Oh, and please remove the buttonizing hover effect on From: label, which isn't conform to standard. But From: label must remain functional to focus From: input field via click or access key Alt+r.
Observed on Windows 10, TB 52.2.1 (32-bit)
The focus indication issue looks like a bug in XUL. I suspect that in general, mouse actions do no longer always cause dotted focus indicator, because there'll be other indication of focus like blue background etc. However, in this particular scenario, a label which focuses a dropdown box, mouse-applied focus via the label is invisible as long as the dropdown isn't open yet, which can't be right. Focus sits correctly, Alt+cursor down will always work to open dropdown after focusing whichever method.
(In reply to Thomas D. (currently busy elsewhere; needinfo?me) from comment #0)
> If composition is started via button click (step A1), the focus indication
> is missing UNTIL step 4, alt+r keyboard shortcut to focus From field. After
> that (step 5), focus indication is always correct until composition is
> closed.

This is wrong. When you use the mouse, there is no need to show the focusring. Only when using the keyboard, the focusring needs to be shown as a feedback to where the actual focus is. With the mouse it's clear where you click. Step 4 is a keyboard activity and shows correctly the focusring.
Fixed in bug 1373397, no?
Not the hover effect of the From: label.
Attached patch Bug1377929.patchSplinter Review
This is a CSS only patch. The JS functionality must be removed sometime.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8883169 - Flags: review?(jorgk)
(In reply to Richard Marti (:Paenglab) from comment #7)
> This is a CSS only patch. The JS functionality must be removed sometime.
Which JS functionality? Can you please paste a DXR reference here. Why can't we remove it now?

Is it really so bad to have a hover effect, at least the user knows that this is an e-mail header field. I guess that was introduced at some stage (in TB 45?) for a reason, no? I can't see it in blame now, since all that code changed when XP/Vista stuff got removed. That said, in TB 38 and earlier, there was no hover effect.
The hover effect is on the label (the "From:"). The intention was to enable the customize the from address in bug 87987. But now i'm not sure if this was removed in the checked-in patch and this functionality never worked and the hover styles where always for nothing.
Comment on attachment 8883169 [details] [diff] [review]
Bug1377929.patch

OK, I'm not 100% convinced, but if two UX people want to reinstate the pre-TB 45 state, I won't oppose that.
Attachment #8883169 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/33ae1055884a922fbf05bdb37452f982bdbc0186
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
You need to log in before you can comment on or make changes to this bug.