1377946 - Don't include promise rejection dates in the first line of failure messages

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, enhancement, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If I'm trying to file a bug for a failure like https://treeherder.mozilla.org/logviewer.html#?job_id=111547789&repo=mozilla-inbound it includes the promise rejection date from the failure line in the summary. That rejection date will never match a future instance of the failure, and takes up a lot of room in the summary that could have gone to the rejection stack, which actually might include useful information.

We should just strip out the rejection date timestamp from the summary when parsing the failure in the bug filer.

Comment 1

[Ed Morley [:emorley]]

I would much prefer to remove the date from the log output rather than have to work around it in Treeherder, if possible?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Maybe we could swap the order so that it prints out the rejection message, stack, then date? We'd get more of the useful bits first.
https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/tests/modules/PromiseTestUtils.jsm#253

Comment 3

[:Paolo Amadini]

Sounds good to me, thanks for reporting the issue!

Comment 4

[:Paolo Amadini]

Attachment: Bug 1377946 - Don't include promise rejection dates in the first line of failure messages.

Review commit: https://reviewboard.mozilla.org/r/154454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154454/

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8883527 [details]
Bug 1377946 - Don't include promise rejection dates in the first line of failure messages.

https://reviewboard.mozilla.org/r/154454/#review159656

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I would've thought there would need to be a test change to accompany this, but my try run doesn't seem to have hit anything complaining about the order changing. Patch looks good on its own, though.

Comment 7

[:Paolo Amadini]

Yeah, I don't think we test log output :-(

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01fdf4dd0a12
Don't include promise rejection dates in the first line of failure messages. r=KWierso

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/01fdf4dd0a12