Don't include promise rejection dates in the first line of failure messages

RESOLVED FIXED in Firefox 56

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: KWierso, Assigned: Paolo)

Tracking

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

()

Attachments

(1 attachment)

If I'm trying to file a bug for a failure like https://treeherder.mozilla.org/logviewer.html#?job_id=111547789&repo=mozilla-inbound it includes the promise rejection date from the failure line in the summary. That rejection date will never match a future instance of the failure, and takes up a lot of room in the summary that could have gone to the rejection stack, which actually might include useful information.

We should just strip out the rejection date timestamp from the summary when parsing the failure in the bug filer.
I would much prefer to remove the date from the log output rather than have to work around it in Treeherder, if possible?
Maybe we could swap the order so that it prints out the rejection message, stack, then date? We'd get more of the useful bits first.
https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/tests/modules/PromiseTestUtils.jsm#253
Flags: needinfo?(paolo.mozmail)
Sounds good to me, thanks for reporting the issue!
Assignee: wkocher → paolo.mozmail
Status: NEW → ASSIGNED
Component: Treeherder → Async Tooling
Flags: needinfo?(paolo.mozmail)
Priority: -- → P1
Product: Tree Management → Toolkit
Summary: Strip out promise rejection dates from failure lines in the bug filer. → Don't include promise rejection dates in the first line of failure messages
Version: --- → Trunk
Comment on attachment 8883527 [details]
Bug 1377946 - Don't include promise rejection dates in the first line of failure messages.

https://reviewboard.mozilla.org/r/154454/#review159656
Attachment #8883527 - Flags: review?(wkocher) → review+
I would've thought there would need to be a test change to accompany this, but my try run doesn't seem to have hit anything complaining about the order changing. Patch looks good on its own, though.
Yeah, I don't think we test log output :-(
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01fdf4dd0a12
Don't include promise rejection dates in the first line of failure messages. r=KWierso
https://hg.mozilla.org/mozilla-central/rev/01fdf4dd0a12
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.