1377948 - MinGW complains abaout unused statements and variables in js/src/vm/Time.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

> In file included from /home/worker/workspace/build/src/obj-firefox/js/src/Unified_cpp_js_src37.cpp:29:0:
> /home/worker/workspace/build/src/js/src/vm/Time.cpp: In function 'size_t PRMJ_FormatTime(char*, int, const char*, PRMJTime*)':
> /home/worker/workspace/build/src/js/src/vm/Time.cpp:353:50: error: statement has no effect [-Werror=unused-value]
>      _CrtSetReportMode(_CRT_ASSERT, oldReportMode);
>                                                   ^
> /home/worker/workspace/build/src/js/src/vm/Time.cpp:272:9: error: variable 'oldReportMode' set but not used [-Werror=unused-but-set-variable]
>      int oldReportMode;

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1377948 Silence two warnings that occur as errors on the MinGW build

Review commit: https://reviewboard.mozilla.org/r/154040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154040/

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8883083 [details]
Bug 1377948 Silence two warnings that occur as errors on the MinGW build

https://reviewboard.mozilla.org/r/154040/#review159176

The warning is because of that MinGW doesn't support _CrtSetReportMode properly, and it has the following definition (or similar)

> #define _CrtSetReportMode(t,f) ((int)0)

so, I guess ignoring the warning is not a good idea here, because it could result in overlooking actual issue elsewhere in the future.

maybe we could enclose those lines by #ifdef _MSC_VER, so that the code is used only in MSVC.

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8883083 [details]
Bug 1377948 Silence two warnings that occur as errors on the MinGW build

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154040/diff/1-2/

Comment 4

[Tooru Fujisawa [:arai]]

Comment on attachment 8883083 [details]
Bug 1377948 Silence two warnings that occur as errors on the MinGW build

https://reviewboard.mozilla.org/r/154040/#review159190

Looks good, supposing it passes try run :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd9b0b8c781c
Silence two warnings that occur as errors on the MinGW build r=arai

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dd9b0b8c781c