Closed
Bug 1377970
Opened 7 years ago
Closed 7 years ago
add -llog for Android in moz.build
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
1.83 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
Adding -llog in this way is cleaner and is just a little bit less m4.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8883108 -
Flags: review?(cmanchester)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8883108 [details] [diff] [review] add -llog for Android in moz.build Review of attachment 8883108 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/autoconf/android.m4 @@ -22,5 @@ > dnl Add --allow-shlib-undefined, because libGLESv2 links to an > dnl undefined symbol (present on the hardware, just not in the > dnl NDK.) > LDFLAGS="-L$android_platform/usr/lib -Wl,-rpath-link=$android_platform/usr/lib --sysroot=$android_platform -Wl,--allow-shlib-undefined $LDFLAGS" > - dnl Add -llog by default, since we use it all over the place. This comment isn't particularly useful, but I suppose we could move it, too.
Attachment #8883108 -
Flags: review?(cmanchester) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6293a69590dc add -llog for Android in moz.build; r=chmanchester
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6293a69590dc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•