1377970 - add -llog for Android in moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

Adding -llog in this way is cleaner and is just a little bit less m4.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: add -llog for Android in moz.build

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8883108 [details] [diff] [review]
add -llog for Android in moz.build

Review of attachment 8883108 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/android.m4
@@ -22,5 @@
>      dnl Add --allow-shlib-undefined, because libGLESv2 links to an
>      dnl undefined symbol (present on the hardware, just not in the
>      dnl NDK.)
>      LDFLAGS="-L$android_platform/usr/lib -Wl,-rpath-link=$android_platform/usr/lib --sysroot=$android_platform -Wl,--allow-shlib-undefined $LDFLAGS"
> -    dnl Add -llog by default, since we use it all over the place.

This comment isn't particularly useful, but I suppose we could move it, too.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6293a69590dc
add -llog for Android in moz.build; r=chmanchester

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6293a69590dc