Closed
Bug 1377989
Opened 7 years ago
Closed 7 years ago
Consider renaming nsRange::mStartParent/mEndParent to mStartContainer/mEndContainer
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: masayuki)
Details
Attachments
(12 files)
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
http://searchfox.org/mozilla-central/rev/a3a739de04ee6134c11546568a33dbb6a6a29907/dom/base/nsRange.h#76-84 "Parent" is a misnomer really, because if the node is a TextNode then it's not a child node that is the start node but the node itself. I suspect this is why the spec is using the term "container" instead: https://dom.spec.whatwg.org/#interface-range Anyway, it would make the code easier to follow for newcomers if it uses the same names as in the spec.
|
Assignee | |
Comment 1•7 years ago
|
||
Taking this for avoiding bug 1375502 to create another set of these names.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9270f50caaf0622251e71094804cc6efd2eb16ab
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8885314 -
Flags: review?(mats) → review?(bugs)
Attachment #8885315 -
Flags: review?(mats) → review?(bugs)
Attachment #8885316 -
Flags: review?(mats) → review?(bugs)
Attachment #8885317 -
Flags: review?(mats) → review?(bugs)
Attachment #8885318 -
Flags: review?(mats) → review?(bugs)
Attachment #8885319 -
Flags: review?(mats) → review?(bugs)
Attachment #8885320 -
Flags: review?(mats) → review?(bugs)
Attachment #8885321 -
Flags: review?(mats) → review?(bugs)
Attachment #8885322 -
Flags: review?(mats) → review?(bugs)
Attachment #8885323 -
Flags: review?(mats) → review?(bugs)
Attachment #8885324 -
Flags: review?(mats) → review?(bugs)
Attachment #8885325 -
Flags: review?(mats) → review?(bugs)
|
|
Assignee | |
Comment 15•7 years ago
|
||
Oops, mats is on vacation, smaug, could you review them? They just simply replace some of them except when the changing line is over 80 chars or using odd style.
|
||
Comment 16•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885314 [details] Bug 1377989 - part1: Rename nsRange::GetStartParent() to nsRange::GetStartContainer() https://reviewboard.mozilla.org/r/156168/#review161306
Attachment #8885314 -
Flags: review?(bugs) → review+
|
|
||
Comment 17•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885315 [details] Bug 1377989 - part2: Rename nsRange::GetEndParent() to nsRange::GetEndContainer() https://reviewboard.mozilla.org/r/156170/#review161308
Attachment #8885315 -
Flags: review?(bugs) → review+
|
|
||
Comment 18•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885316 [details] Bug 1377989 - part3: Rename nsRange::GetParentAndOffsetAfter() to nsRange::GetContainerAndOffsetAfter() https://reviewboard.mozilla.org/r/156172/#review161310
Attachment #8885316 -
Flags: review?(bugs) → review+
|
|
||
Comment 19•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885317 [details] Bug 1377989 - part4: Rename nsRange::GetParentAndOffsetBefore() to nsRange::GetContainerAndOffsetBefore() https://reviewboard.mozilla.org/r/156174/#review161312
Attachment #8885317 -
Flags: review?(bugs) → review+
|
|
||
Comment 20•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885318 [details] Bug 1377989 - part5: Rename mStartParent of nsRange and similar members of similar objects to mStartContainer https://reviewboard.mozilla.org/r/156176/#review161314
Attachment #8885318 -
Flags: review?(bugs) → review+
|
|
||
Comment 21•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885319 [details] Bug 1377989 - part6: Rename mEndParent of nsRange and similar members of similar objects to mEndContainer https://reviewboard.mozilla.org/r/156178/#review161318
Attachment #8885319 -
Flags: review?(bugs) → review+
|
|
||
Comment 22•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885320 [details] Bug 1377989 - part7: Rename aParent, aParentNode and aNode related to nsRange to aContainer https://reviewboard.mozilla.org/r/156180/#review161320
Attachment #8885320 -
Flags: review?(bugs) → review+
|
|
||
Comment 23•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885321 [details] Bug 1377989 - part8: Rename aStartParent and aStartNode related to nsRange to aStartContainer https://reviewboard.mozilla.org/r/156182/#review161330
Attachment #8885321 -
Flags: review?(bugs) → review+
|
|
||
Comment 24•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885322 [details] Bug 1377989 - part9: Rename aEndParent and aEndNode related to nsRange to aEndContainer https://reviewboard.mozilla.org/r/156184/#review161332
Attachment #8885322 -
Flags: review?(bugs) → review+
|
|
||
Comment 25•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885323 [details] Bug 1377989 - part10: Rename local variables, |parent| which is set to container of nsRange to |container| https://reviewboard.mozilla.org/r/156186/#review161334
Attachment #8885323 -
Flags: review?(bugs) → review+
|
|
||
Comment 26•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885324 [details] Bug 1377989 - part11: Rename local variables, |startParent| which is set to start container of nsRange to |startContainer| https://reviewboard.mozilla.org/r/156188/#review161338
Attachment #8885324 -
Flags: review?(bugs) → review+
|
|
||
Comment 27•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885325 [details] Bug 1377989 - part12: Rename local variables, |endParent| which is set to start container of nsRange to |endContainer| https://reviewboard.mozilla.org/r/156190/#review161340
Attachment #8885325 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 28•7 years ago
|
||
Wow, really quick review, thank you very much! And sorry for taking your time.
|
||
Comment 29•7 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/0dc608377abd part1: Rename nsRange::GetStartParent() to nsRange::GetStartContainer() r=smaug https://hg.mozilla.org/integration/autoland/rev/071e78737dde part2: Rename nsRange::GetEndParent() to nsRange::GetEndContainer() r=smaug https://hg.mozilla.org/integration/autoland/rev/0823fc5ae61e part3: Rename nsRange::GetParentAndOffsetAfter() to nsRange::GetContainerAndOffsetAfter() r=smaug https://hg.mozilla.org/integration/autoland/rev/f2ed8c2d2499 part4: Rename nsRange::GetParentAndOffsetBefore() to nsRange::GetContainerAndOffsetBefore() r=smaug https://hg.mozilla.org/integration/autoland/rev/21a1597968b2 part5: Rename mStartParent of nsRange and similar members of similar objects to mStartContainer r=smaug https://hg.mozilla.org/integration/autoland/rev/22dc839060b2 part6: Rename mEndParent of nsRange and similar members of similar objects to mEndContainer r=smaug https://hg.mozilla.org/integration/autoland/rev/c557e2f2142b part7: Rename aParent, aParentNode and aNode related to nsRange to aContainer r=smaug https://hg.mozilla.org/integration/autoland/rev/56af7270cb55 part8: Rename aStartParent and aStartNode related to nsRange to aStartContainer r=smaug https://hg.mozilla.org/integration/autoland/rev/e7ed833f7da3 part9: Rename aEndParent and aEndNode related to nsRange to aEndContainer r=smaug https://hg.mozilla.org/integration/autoland/rev/14377a3781bd part10: Rename local variables, |parent| which is set to container of nsRange to |container| r=smaug https://hg.mozilla.org/integration/autoland/rev/c065b1854076 part11: Rename local variables, |startParent| which is set to start container of nsRange to |startContainer| r=smaug https://hg.mozilla.org/integration/autoland/rev/c780d92e3fed part12: Rename local variables, |endParent| which is set to start container of nsRange to |endContainer| r=smaug
|
||
Comment 30•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0dc608377abd https://hg.mozilla.org/mozilla-central/rev/071e78737dde https://hg.mozilla.org/mozilla-central/rev/0823fc5ae61e https://hg.mozilla.org/mozilla-central/rev/f2ed8c2d2499 https://hg.mozilla.org/mozilla-central/rev/21a1597968b2 https://hg.mozilla.org/mozilla-central/rev/22dc839060b2 https://hg.mozilla.org/mozilla-central/rev/c557e2f2142b https://hg.mozilla.org/mozilla-central/rev/56af7270cb55 https://hg.mozilla.org/mozilla-central/rev/e7ed833f7da3 https://hg.mozilla.org/mozilla-central/rev/14377a3781bd https://hg.mozilla.org/mozilla-central/rev/c065b1854076 https://hg.mozilla.org/mozilla-central/rev/c780d92e3fed
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•