Closed Bug 1378011 Opened 5 years ago Closed 5 years ago

Remove some unused stuff from the Legacy HTML Parser

Categories

(Core :: DOM: HTML Parser, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(2 files)

I found some unused stuff.
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
It's unused except in test code (nsTestEntityTable). The patch removes that
test code, which also removes testing for UnicodeToEntity conversion, but the
test code wasn't being run anyway so it's no great loss.

(UnicodeToEntity conversion is still used by
nsHTMLContentSerializer::AppendAndTranslateEntities().)
Attachment #8883145 - Flags: review?(mrbkap)
On 64-bit platforms part 2 saves 8240 B of memory per process, so 5 KiB in total when running with four content processes.
Comment on attachment 8883144 [details] [diff] [review]
(part 1) - Remove nsToken.h, because it is unused

Review of attachment 8883144 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for noticing this.
Attachment #8883144 - Flags: review?(mrbkap) → review+
Attachment #8883145 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9b15e6899fe0d1c0a3d4838f32f75a5deda9502
Bug 1378011 (part 1) - Remove nsToken.h, because it is unused. r=mrbkap.

https://hg.mozilla.org/integration/mozilla-inbound/rev/92c0c378bcaf0b37a2673905d43a18d751b61a92
Bug 1378011 (part 2) - Remove the Legacy HTML Parser's EntityToUnicode conversions. r=mrbkap.
https://hg.mozilla.org/mozilla-central/rev/d9b15e6899fe
https://hg.mozilla.org/mozilla-central/rev/92c0c378bcaf
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.