Closed Bug 137802 Opened 24 years ago Closed 23 years ago

nsHTTPChunkConv is unused and should be removed

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: timeless, Assigned: darin.moz)

References

(
URL
)

Details

(Keywords: helpwanted, Whiteboard: [good first bug])

Attachments

(1 file)

removal
12.63 KB, patch
dwitte
: review+
dwitte
: superreview+
tor
: approval1.4b+
Details | Diff | Splinter Review
ruslan (1 warning) 1. netwerk/streamconv/converters/nsHTTPChunkConv.cpp:421 (See build log excerpt) Enumeration value `CHUNK_STATE_DONE' not handled in switch 419 420 break; 421 } /* switch */ 422 } /* while */ 423 } /* DO_UNCHUNKING */
nsHTTPChunkConv.cpp is unused.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → INVALID
if it's unused, can we remove it from the build?
yes.. i've always meant to do so, but just haven't gotten around to it.
http://lxr.mozilla.org/seamonkey/ident?i=NS_NewHTTPChunkConv it looks kind of used...
it's registered with the stream converter service, but otherwise it is not used. it's part of the old HTTP implementation... the new HTTP implementation has its own built-in chunked decoder (see nsHttpChunkedDecoder). reopening this bug to track removing nsHTTPChunkConv.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: Enumeration value `CHUNK_STATE_DONE' not handled in switch → nsHTTPChunkConv is unused and should be removed
Target Milestone: --- → Future
If someone gets bored.. ;)
Keywords: helpwanted
Whiteboard: [good first bug]
bz: gee, thanks. ;) looks like the files were removed 09/10/02: http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/netwerk/streamconv/converters/Attic/nsHTTPChunkConv.cpp&rev=&root=/cvsroot but the module factory still has some leftover cruft from them.
actually, the entire nsConvFactories.cpp factory is cruft - it's not built anymore ;) darin, can we remove that file?
yes, we can. wanna do the typing? ;-)
Attached patch removal — — Splinter Review
Comment on attachment 122111 [details] [diff] [review] removal r+sr=darin as noted above.
Attachment #122111 - Flags: superreview+
Attachment #122111 - Flags: review+
Comment on attachment 122111 [details] [diff] [review] removal requesting approval for removal of an obsolete, not-part-of-build file.
Attachment #122111 - Flags: approval1.4b?
Comment on attachment 122111 [details] [diff] [review] removal a=tor for 1.4b on behalf of drivers
Attachment #122111 - Flags: approval1.4b? → approval1.4b+
done.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: