Closed
Bug 1378061
Opened 7 years ago
Closed 7 years ago
Only set user's SID in USER_LIMITED as deny only when not using restricting SIDs.
Categories
(Core :: Security: Process Sandboxing, defect)
Tracking
()
RESOLVED
FIXED
mozilla56
People
(Reporter: bobowen, Assigned: bobowen)
References
Details
(Whiteboard: sbwc2)
Attachments
(1 file)
1.69 KB,
patch
|
jimm
:
review+
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This change from bug 1323188 broke web audio and some other things in the restricting SIDs (normal) case. It possibly will still break web audio when running from a network drive, but I'll pick that up in a separate bug.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bobowencode
Status: NEW → ASSIGNED
status-firefox55:
--- → affected
status-firefox56:
--- → affected
Whiteboard: sbwc2
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8883213 -
Flags: review?(jmathies)
Updated•7 years ago
|
Attachment #8883213 -
Flags: review?(jmathies) → review+
Pushed by bobowencode@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/04edb03fb817 Only set user's SID in USER_LIMITED as deny only when not using restricting SIDs. r=jimm
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/04edb03fb817
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 5•7 years ago
|
||
Bob, is this something you would like to be in 55? If so, can you request uplift?
tracking-firefox55:
--- → +
Flags: needinfo?(bobowencode)
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5) > Bob, is this something you would like to be in 55? If so, can you request > uplift? We're not using USER_LIMITED in 55, but we might need to uplift this to make another uplift clean for bug 1377555. I'll make sure we request at the same time if we do.
Flags: needinfo?(bobowencode)
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8883213 [details] [diff] [review] Only set user's SID in USER_LIMITED as deny only when not using restricting SIDs Approval Request Comment [Feature/Bug causing the regression]: Bug 1323188, also required for uplift of bugs 1377555 and 1377249 [User impact if declined]: Bug 1377249 will not be able to be uplifted. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Verified in local build. [Needs manual test from QE? If yes, steps to reproduce]: Bug 1377555 actually backs-out and re-implements this change so no. [List of other uplifts needed for the feature/fix]: Bug 1377555 and 1377249, should be uplifted after this. [Is the change risky?]: No. [Why is the change risky/not risky?]: This change is very simple [String changes made/needed]: None
Attachment #8883213 -
Flags: approval-mozilla-beta?
Comment 8•7 years ago
|
||
Comment on attachment 8883213 [details] [diff] [review] Only set user's SID in USER_LIMITED as deny only when not using restricting SIDs this is needed for some other fixes, beta55+
Attachment #8883213 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/6075562b897b
Comment 10•7 years ago
|
||
(In reply to Bob Owen (:bobowen) from comment #7) > [Is this code covered by automated tests?]: > No > > [Has the fix been verified in Nightly?]: > Verified in local build. > > [Needs manual test from QE? If yes, steps to reproduce]: > Bug 1377555 actually backs-out and re-implements this change so no. Setting qe-verify- based on Bob's assessment on manual testing needs.
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•