Closed Bug 1378072 Opened 4 years ago Closed 4 years ago

[Form Autofill] Update the locale of phishing warning note to align with the latest UX spec

Categories

(Toolkit :: Form Manager, enhancement)

Product:
Toolkit
Component:
Form Manager
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: ralin, Assigned: ralin)

References

Details

(Whiteboard: [form autofill:M4] [ETA:7/21])

Attachments

(1 file)

Bug 1378072 - Update entity name of the warning note and its string as the meaning is slightly changed in the latest UX spec.
59 bytes, text/x-review-board-request
lchang
: review+
Details 
The spec has been updated since last review, we should update the string correspondingly.
Status: NEW → ASSIGNED
Whiteboard: [form autofill:M4] → [form autofill:M4] [ETA:7/21]
Comment on attachment 8884506 [details]
Bug 1378072 - Update entity name of the warning note and its string as the meaning is slightly changed in the latest UX spec.

https://reviewboard.mozilla.org/r/155400/#review162702

::: browser/extensions/formautofill/locale/en-US/formautofill.properties:33
(Diff revision 1)
>  # LOCALIZATION NOTE (phishingWarningMessage, phishingWarningMessage2): The warning
>  # text that is displayed for informing users what categories are about to be filled.
>  # "%S" will be replaced with a list generated from the pre-defined categories.
> -# The text would be e.g. Also fill company, phone, email
> -phishingWarningMessage = Also fill %S
> -phishingWarningMessage2 = Fill %S
> +# The text would be e.g. Also autofills company, phone, email
> +phishingAutofillWarningMessage = Also autofills %S
> +phishingAutofillWarningMessage2 = Autofills %S

nit: How about make "Message2" more meaningful?

BTW, you don't have to change the ID since L10N hasn't been involved yet.
Attachment #8884506 - Flags: review?(lchang) → review+
Comment on attachment 8884506 [details]
Bug 1378072 - Update entity name of the warning note and its string as the meaning is slightly changed in the latest UX spec.

https://reviewboard.mozilla.org/r/155400/#review162702

Issue fixed, thanks
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9c869c35cb7b
Update entity name of the warning note and its string as the meaning is slightly changed in the latest UX spec. r=lchang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9c869c35cb7b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.