1378136 - Wrong Change search settings redirection from about:newtab and about:home

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Petruta Horea [:phorea], Desktop QA]

+++ This bug was initially created as a clone of Bug #1372528 +++

[Note]:
- This doesn't reproduce on Firefox 54 beta 13 with one-off searches from awesome bar force enabled 

[Affected versions]:
- Firefox 55 beta 6
- Nightly 56.0a1

[Affected platforms]:
- Win 10 64-bit
- Mac OS X 10.12.5
- Ubuntu 14.04 64-bit

[Steps to reproduce]:
1. Open about:newtab and about:home
2. Enter some text in Search field to open dropdown
3. Select "Change Search Settings" button

[Expected result]:
- On Beta: about:preferences#search opens
- On Nightly: about:preferences#general with focus on Search opens (just like when selecting the button from Search toolbar)

[Actual result]:
- On Beta: about:preferences#general opens
- On Nightly: Focus is on General, not on Search

[Regression range]:
- This happened after bug 1335907 landed (about:preferences reorg)

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Francis, this is regressed from bug 135907 on FF55. How are we concerned this on 55 as preferences reorg doesn't ride 55?
Could you take this into photon-preferences triage and suggest the next step for 55? Thanks!

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

[Tracking Requested - why for this release]: Regression on Fx55, button behavior does not respect pref-off flag.

(In reply to Hsin-Yi Tsai (55 Regression Engineering support) [:hsinyi] from comment #1)
> Hi Francis, this is regressed from bug 135907 on FF55. How are we concerned
> this on 55 as preferences reorg doesn't ride 55?
> Could you take this into photon-preferences triage and suggest the next step
> for 55? Thanks!

It affects Fx55 because the said bug in Fx55 prevents the button to respect the pref-off flag. On Fx55 since we are still use old pref page user should be direct to about:preferences#search instead of about:preferences#general.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1378136 - Redirect user to the general pane for search settings on old preferences page.

Review commit: https://reviewboard.mozilla.org/r/155648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155648/

Comment 4

[Julien Cristau [:jcristau]]

Regression in home screen in 55, tracking.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8884768 [details]
Bug 1378136 - Redirect user to the general pane for search settings on old preferences page.

https://reviewboard.mozilla.org/r/155648/#review161436

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5de4f401f4ec4eece54bc55e5fce7cbe37c35e98

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/312f5e3f6a7c
Redirect user to the general pane for search settings on old preferences page. r=jaws

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/312f5e3f6a7c

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Uplift request needed.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8884768 [details]
Bug 1378136 - Redirect user to the general pane for search settings on old preferences page.

Approval Request Comment
[Feature/Bug causing the regression]: regression from bug 1335907 
[User impact if declined]: The button will send the user to wrong section of the  Preferences page
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: I've verified it manually, but QA has not
[Needs manual test from QE? If yes, steps to reproduce]: 
Use comment 0, but set browser.preferences.useOldOrganization to true in about:config to simulate the current pref in Beta.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No. It's not a critical feature. Just confusing.
[Why is the change risky/not risky?]: 
[String changes made/needed]: None

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8884768 [details]
Bug 1378136 - Redirect user to the general pane for search settings on old preferences page.

yet more useOldOrganization preferences fallout.  should be in 55.0b11

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cbaff692f6fe

Comment 13

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 55 beta 12 across platforms.
On Nightly 56.0a1 this fails again due to bug 1365133 (preferences reorg v2) - logged follow-up bug 1384068 for this.

Comment 14

[Deac Alin]

Tested on Windows 10 x64, Mac OS X 10.12 and Ubuntu 16.04. The issue is verified fixed as following, after step 3(same result for both builds and all OS):
 -Latest Nightly :  about:preferences#search with focus on Search opens 
 -Latest Beta    :  about:preferences#search with focus on Search opens 
One additional note:
After the new preferences reorg V2, the Expected for this issue should be changed to:
"On Nightly: about:preferences#search with focus on Search opens"
from 
"On Nightly: about:preferences#general with focus on Search opens (just like when selecting the button from Search toolbar)"
Thank you.