Closed
Bug 1378153
Opened 7 years ago
Closed 7 years ago
Dev Edition no longer opens correct /firstrun or /whatsnew URLs
Categories
(www.mozilla.org :: Pages & Content, enhancement)
Tracking
(firefox57 fixed, firefox58 fixed)
RESOLVED
FIXED
People
(Reporter: agibson, Assigned: catlee)
References
Details
Attachments
(1 file)
Now that Developer Edition has become part of the Beta channel, are the Dev Edition specific /whatsnew [1] or /firstrun [2] pages are still needed? [1] https://www.mozilla.org/en-US/firefox/54.0a2/whatsnew/ [2] https://www.mozilla.org/en-US/firefox/54.0a2/firstrun/ If the product is no longer opening these URLs, can we remove the templates?
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(erenaud)
Comment 1•7 years ago
|
||
We need to keep them - per Bryan Clark - "we wanted to keep them on the aurora templates those have the developer focused copy"
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(erenaud)
Resolution: --- → FIXED
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Eric Renaud from comment #1) > We need to keep them - per Bryan Clark - "we wanted to keep them on the > aurora templates those have the developer focused copy"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 3•7 years ago
|
||
Before we close this, I need to understand how this is happening? The URLs above e.g 54.0a2 are Aurora channel specific, but dev edition is now part of the Beta channel. How is this being handled, does is still have Aurora version numbers in the product, or do we need to adjust anything on our end?
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(erenaud)
Reporter | ||
Comment 4•7 years ago
|
||
To be more specific, my concern here is whether we still have a way to distinguish dev edition from the regular beta build. Without a specific version number passed from in-product, we can't easily display a dev edition specific template without Beta channel users also seeing it.
Reporter | ||
Comment 5•7 years ago
|
||
Launching Dev Edition 55 with a new profile I can confirm the browser opens https://www.mozilla.org/en-US/firefox/55.0/firstrun/ which is the incorrect page. The product no longer passes `a2` at the end of the version number since it is now on the Beta channel, so mozorg has no way to tell if the request is from is Developer Edition or not. If marketing would like to keep these pages around, we need some way to distinguish in the version number. The only option we currently have is UITour which can give us the value for defaultUpdateChannel ('aurora' still in this case it seems, oddly enough), however this is handled via client side JS, so it would require a redirect happening after the regular /firstrun page loads, which is not a good experience for first-time users imo. This is probably something that should be fixed in-product.
Summary: Decommission Dev Edition /firstrun and /whatsnew pages. → Dev Edition no longer opens correct /firstrun or /whatsnew URLs
Comment 6•7 years ago
|
||
I noted the same - the /55.0/firstrun page along two other tabs. Very strange. I'll keep talking w. Product and the TL&I (formerly known as DevMarketing) about this.
Flags: needinfo?(erenaud)
Reporter | ||
Comment 7•7 years ago
|
||
HI Eric, any updates here? If these pages are no longer opened in-product and they have no immediate plans to fix the issue, I suggest we go ahead with removing these pages. They are already long out of date brand-wise, and keeping them around long term is likely just adding to maintenance of pages people no longer see. Through the wonderous powers of Git, nothing is gone forever and can always be resurrected (although I doubt we would ressurect, as we would likely just redesign instead).
Flags: needinfo?(erenaud)
Comment 8•7 years ago
|
||
TL & I wants to use these pages with the dev edition (after redesigning, which is wanted for Sept 26 with the 56 release . . .). Arcadio is reaching out to the folks in product with the request to get those back in. Arcadio - please see Alex's statements in comment5 about the best means for distinguishing the channel being in product. As you speak to those folks, please make that part of your request.
Flags: needinfo?(erenaud) → needinfo?(alainez)
Reporter | ||
Comment 9•7 years ago
|
||
I very much doubt this will be fixed in time for 56 I understand the wish to re-instate these pages, but "keeping them around" is really not worth much if they are to be redesigned anyway.
Reporter | ||
Comment 10•7 years ago
|
||
Does anyone even know if dev-edition can still trigger a /whatsnew independent on the regular Beta package? These are all questions that we should have answers to before comitting to developing any pages for this.
Comment 11•7 years ago
|
||
(In reply to Eric Renaud from comment #8) > TL & I wants to use these pages with the dev edition (after redesigning, > which is wanted for Sept 26 with the 56 release . . .). Arcadio is reaching > out to the folks in product with the request to get those back in. > > Arcadio - please see Alex's statements in comment5 about the best means for > distinguishing the channel being in product. As you speak to those folks, > please make that part of your request. I'm going to NI Harald and Verdi. Eric can you add them to the bug and help us track this work?
Flags: needinfo?(mverdi)
Flags: needinfo?(hkirschner)
Flags: needinfo?(alainez)
Comment 12•7 years ago
|
||
I don't have the answers to Alex's technical questions. What I do know is that Dev Edition needs it's own firstrun and what's new pages and they should not be the same as beta/release.
Flags: needinfo?(mverdi)
Comment 13•7 years ago
|
||
Tom was involved with past discussions about DevEdition builds. From the product side, I would expect that we should be able to customize the first launch URL, but Tom can hopefully confirm the technical question.
Flags: needinfo?(hkirschner) → needinfo?(ttromey)
Comment 14•7 years ago
|
||
(In reply to Alex Gibson [:agibson] from comment #10) > Does anyone even know if dev-edition can still trigger a /whatsnew > independent on the regular Beta package? These are all questions that we > should have answers to before comitting to developing any pages for this. If I'm reading the code correctly, these URLs come from the startup.homepage_override_url and startup.homepage_welcome_url prefs. https://dxr.mozilla.org/mozilla-central/rev/93dd2e456c0ecca00fb4d28744e88078a77deaf7/browser/branding/nightly/pref/firefox-branding.js#5-6 So, I think the links can be changed by setting these prefs in a devedition-specific way. However, I'm not 100% certain. I'm forwarding the NI to the person who reviewed the last change to those lines.
Flags: needinfo?(ttromey) → needinfo?(adw)
Comment 15•7 years ago
|
||
(In reply to Tom Tromey :tromey from comment #14) > If I'm reading the code correctly, these URLs come from the > startup.homepage_override_url > and startup.homepage_welcome_url prefs. Yes, that's right. (Bug 983453 has context about these prefs that might be useful, especially Gavin's comment 5 and Matt's comment 13.) It should be possible to add an #ifdef to this prefs file for dev edition (assuming there's a macro and this file is pre-processed, I don't know).
Flags: needinfo?(adw)
Comment 16•7 years ago
|
||
Lawrence, we are running out of options for people to ask. Who might knows for sure how to customize the first-load URL for DevEdition and if the file that holds the config is pre-processed?
Flags: needinfo?(lmandel)
Comment 17•7 years ago
|
||
I thinking releng will know if and how we can set customer whatsnew URLs as part of the build. catlee - Can we specify different whatsnew URLs for Dev Edition as part of the build config? If so, how do we go about doing that?
Flags: needinfo?(lmandel) → needinfo?(catlee)
Assignee | ||
Comment 18•7 years ago
|
||
DevEdition still uses the the aurora branding: https://dxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/macosx64/devedition#25 So you should be able to adjust the firstrun URL here: https://dxr.mozilla.org/mozilla-central/rev/93dd2e456c0ecca00fb4d28744e88078a77deaf7/browser/branding/aurora/pref/firefox-branding.js#5-6 The whatsnew page is controlled by the update server. We can point that at any URL, or add an extra query arg to indicate that the user is on DevEdition.
Flags: needinfo?(catlee)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8907604 -
Flags: review?(sledru)
Assignee | ||
Comment 20•7 years ago
|
||
The patch above is to adjust the firstrun page for DevEdition users. Do you also want a whatsnew page for users upgrading from 56.0 devedition? What URLs should we use for that?
Flags: needinfo?(agibson)
Comment 21•7 years ago
|
||
mozreview-review |
Comment on attachment 8907604 [details] Bug 1378153: Add 'a2' to aurora/devedition branding's firstrun page https://reviewboard.mozilla.org/r/179288/#review185002 lgtm
Attachment #8907604 -
Flags: review+
Reporter | ||
Comment 22•7 years ago
|
||
(In reply to Chris AtLee [:catlee] from comment #20) > The patch above is to adjust the firstrun page for DevEdition users. > > Do you also want a whatsnew page for users upgrading from 56.0 devedition? > What URLs should we use for that? Yes please, /firefox/%VERSION%a2/whatsnew/
Flags: needinfo?(agibson)
Comment hidden (obsolete) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → catlee
Assignee | ||
Comment 24•7 years ago
|
||
I filed bug 1399849 to track setting up the whatsnewpage.
Comment hidden (obsolete) |
Assignee | ||
Comment 26•7 years ago
|
||
We need to back out 754d3df0517d5c374ac2b1515fab3621892c327d and from beta for now. We may land again later.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 27•7 years ago
|
||
backout |
https://hg.mozilla.org/integration/autoland/rev/ca18e7c2cadce9c93ea3eb89cc129dc37ca4c091 Will push the backout to Beta once the merge is complete.
Keywords: leave-open
Comment hidden (obsolete) |
Comment 29•7 years ago
|
||
To be clear, comment 28 was just the original push to autoland from comment 23 going to m-c. The backout from comment 27 came after that and still reflects reality.
Assignee | ||
Comment 30•7 years ago
|
||
uplift |
I grafted to beta: https://hg.mozilla.org/releases/mozilla-beta/rev/e85c29016601
Updated•7 years ago
|
status-firefox57:
fixed → ---
Updated•7 years ago
|
Attachment #8907604 -
Flags: review?(sledru)
Comment 32•7 years ago
|
||
Hello - the dev ed /whatsnew and /firstrun pages have been r+ed and will be live before the b4. So, specific to this bug, we're requesting /firefox/%VERSION%a2/firstrun/ be pointed to in the release.
Flags: needinfo?(catlee)
Comment 33•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d0d55a7af17 Add 'a2' to aurora/devedition branding's firstrun page. r=jcristau
Comment 34•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/058e8c2cba28
status-firefox57:
--- → fixed
Comment 35•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d0d55a7af17
Comment 36•7 years ago
|
||
I think this can be marked fixed now.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox58:
--- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(catlee)
You need to log in
before you can comment on or make changes to this bug.
Description
•