"New to Firefox" badge on onboarding takes up too much space when spanning on two rows

VERIFIED FIXED in Firefox 56

Status

()

Firefox
New Tab Page
P1
normal
VERIFIED FIXED
5 months ago
5 months ago

People

(Reporter: flod, Assigned: timdream)

Tracking

56 Branch
Firefox 56
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: [photon-onboarding])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

5 months ago
Created attachment 8883332 [details]
badge.png

Italian text is not much longer than English, but it spans on two lines and the result is quite ugly.

It also looks like some icons are not being displayed completely, and cut on the right.
(Reporter)

Comment 1

5 months ago
Created attachment 8883334 [details]
overlaps.png

It's also quite easy to get elements overlapping

Updated

5 months ago
status-firefox56: --- → affected
Component: General → Theme
Whiteboard: [photon-visual]

Updated

5 months ago
Component: Theme → New Tab Page
Whiteboard: [photon-visual] → [photon-onboarding][triage]
Assignee: nobody → timdream
Status: NEW → ASSIGNED

Updated

5 months ago
Flags: qe-verify+
QA Contact: jwilliams
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Comment hidden (mozreview-request)
(Reporter)

Comment 3

5 months ago
mozreview-review
Comment on attachment 8883836 [details]
Bug 1378168 - Ensure overlay notification icon sizing.

https://reviewboard.mozilla.org/r/154784/#review159808

::: commit-message-af046:1
(Diff revision 1)
> +Bug 1378168 - Ensure overlay notification icon sizing, r=mossip

Mispelled nickname. Besides, this doesn't solve the issue of the badge being fat (is that line-height really needed?)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Updated

5 months ago
Priority: -- → P1
Target Milestone: --- → Firefox 56

Updated

5 months ago
Duplicate of this bug: 1377973

Comment 7

5 months ago
mozreview-review
Comment on attachment 8883836 [details]
Bug 1378168 - Ensure overlay notification icon sizing.

https://reviewboard.mozilla.org/r/154784/#review160332

I'm not sure I understand what this is doing, can you explain?
This does two things:

1. Make sure #onboarding-notification-tour-icon is at least 64px width.
2. For the "New to Nightly" bubble, spare 3px padding at top and bottom and set the line-height to 16px, keeps the bubble at 22px but not 44px height when there are two line texts (new height for two lines: 3+16+16+3 = 38px).
Flags: needinfo?(dtownsend)

Comment 9

5 months ago
mozreview-review
Comment on attachment 8883836 [details]
Bug 1378168 - Ensure overlay notification icon sizing.

https://reviewboard.mozilla.org/r/154784/#review160836
Attachment #8883836 - Flags: review?(dtownsend) → review+

Updated

5 months ago
Flags: needinfo?(dtownsend)
Keywords: checkin-needed

Comment 10

5 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b6cb72de33af
Ensure overlay notification icon sizing. r=mossop
Keywords: checkin-needed
Note that with bug 1358970 this bug might not be fully reproducible, since the notification will simply be hidden with smaller window size.

Comment 12

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b6cb72de33af
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
I have reproduced this bug with nightly 56.0a1 (2017-07-04) on Linux Mint (64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1

Build ID 	20170714100217
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170712]

Updated

5 months ago
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
You need to log in before you can comment on or make changes to this bug.