Closed Bug 1378200 Opened 3 years ago Closed 2 years ago

Consider removing the MOZ_PERMISSIONS define guards

Categories

(Core :: Permission Manager, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Nika, Assigned: prathiksha, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

I'm not sure if we can even build firefox anymore without this component enabled. It might be worthwhile to remove all mentions of the #define which controls whether or not it is in our code.
Could this be a good first bug? Can we assign you as mentor then? :)
Priority: -- → P5
Mentor: nika
Keywords: good-first-bug
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Comment on attachment 8937114 [details]
Bug 1378200 - Remove MOZ_PERMISSIONS define guards.

https://reviewboard.mozilla.org/r/207812/#review213710

lgtm. thanks :-)
Attachment #8937114 - Flags: review?(nika) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e349655b92d
Remove MOZ_PERMISSIONS define guards. r=mystor
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3e349655b92d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.