Closed
Bug 1378200
Opened 7 years ago
Closed 6 years ago
Consider removing the MOZ_PERMISSIONS define guards
Categories
(Core :: Permission Manager, enhancement, P5)
Core
Permission Manager
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: nika, Assigned: prathiksha, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
I'm not sure if we can even build firefox anymore without this component enabled. It might be worthwhile to remove all mentions of the #define which controls whether or not it is in our code.
Comment 1•7 years ago
|
||
Could this be a good first bug? Can we assign you as mentor then? :)
Priority: -- → P5
Reporter | ||
Updated•7 years ago
|
Mentor: nika
Keywords: good-first-bug
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8937114 [details] Bug 1378200 - Remove MOZ_PERMISSIONS define guards. https://reviewboard.mozilla.org/r/207812/#review213710 lgtm. thanks :-)
Attachment #8937114 -
Flags: review?(nika) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3e349655b92d Remove MOZ_PERMISSIONS define guards. r=mystor
Keywords: checkin-needed
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3e349655b92d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•