1378209 - Add INFO log lines for how Marionette got started (command line / environment variable)

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now we only log when the server got started. This is not helpful in cases when some events never come through. So it is not clear if Marionette got started or not.

To give better help for investigating issues we should add INFO log lines for the checks of the command line versus the environment variable.

This might help us to get closer to the underlying problem with bug 1261598.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1378209 - Add INFO log lines for how Marionette got started.

It is helpful to let the user know how Marionette get started. So
INFO log lines have to be added for the command line argument and
the environment variable.

This is especially helpful to get in case of missing observer
notifications, under which the server socket is not getting
created, and the client just hangs.

Review commit: https://reviewboard.mozilla.org/r/154414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154414/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1378209 - Add DEBUG log line for received observer notifications.

For debugging purposes it would be useful to see which observer
notifications have been received and handled by the Marionette
component.

Review commit: https://reviewboard.mozilla.org/r/154416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154416/

Comment 3

[David Burns :automatedtester]

Comment on attachment 8883505 [details]
Bug 1378209 - Add DEBUG log line for received observer notifications.

https://reviewboard.mozilla.org/r/154416/#review159546

Comment 4

[David Burns :automatedtester]

Comment on attachment 8883504 [details]
Bug 1378209 - Add INFO log lines for how Marionette got started.

https://reviewboard.mozilla.org/r/154414/#review159548

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99f54985559b
Add INFO log lines for how Marionette got started. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/6907da68e311
Add DEBUG log line for received observer notifications. r=automatedtester

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/99f54985559b
https://hg.mozilla.org/mozilla-central/rev/6907da68e311

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Test-only patch which help help in diagnosing test failures. Lets uplift to beta, and if it also applies cleanly to esr52. Thanks.

Comment 8

[Carsten Book [:Tomcat]]

has problems to apply to beta

grafting 427870:99f54985559b "Bug 1378209 - Add INFO log lines for how Marionette got started. r=automatedtester"
merging testing/marionette/components/marionette.js
warning: conflicts while merging testing/marionette/components/marionette.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The 2 patches to uplift can be found on top of the changes for the following try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5244d59e9f3df88a92204b1c9d97aec16450d169

https://hg.mozilla.org/try/rev/b8049ca3dbdfc3e672ea4d8b099455bf4d498618
https://hg.mozilla.org/try/rev/b40db608adc0e4ec2680febef343da0c13221d95

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b3fbfc8eb689
https://hg.mozilla.org/releases/mozilla-beta/rev/06dc3565c7c0