Closed Bug 1378209 Opened 3 years ago Closed 3 years ago

Add INFO log lines for how Marionette got started (command line / environment variable)

Categories

(Testing :: Marionette, enhancement)

52 Branch
enhancement
Not set
normal

Tracking

(firefox-esr52 fix-optional, firefox55 fixed, firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr52 --- fix-optional
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(2 files)

Right now we only log when the server got started. This is not helpful in cases when some events never come through. So it is not clear if Marionette got started or not.

To give better help for investigating issues we should add INFO log lines for the checks of the command line versus the environment variable.

This might help us to get closer to the underlying problem with bug 1261598.
Comment on attachment 8883505 [details]
Bug 1378209 - Add DEBUG log line for received observer notifications.

https://reviewboard.mozilla.org/r/154416/#review159546
Attachment #8883505 - Flags: review?(dburns) → review+
Comment on attachment 8883504 [details]
Bug 1378209 - Add INFO log lines for how Marionette got started.

https://reviewboard.mozilla.org/r/154414/#review159548
Attachment #8883504 - Flags: review?(dburns) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99f54985559b
Add INFO log lines for how Marionette got started. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/6907da68e311
Add DEBUG log line for received observer notifications. r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/99f54985559b
https://hg.mozilla.org/mozilla-central/rev/6907da68e311
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Test-only patch which help help in diagnosing test failures. Lets uplift to beta, and if it also applies cleanly to esr52. Thanks.
Whiteboard: [checkin-needed-beta][checkin-needed-esr52]
has problems to apply to beta

grafting 427870:99f54985559b "Bug 1378209 - Add INFO log lines for how Marionette got started. r=automatedtester"
merging testing/marionette/components/marionette.js
warning: conflicts while merging testing/marionette/components/marionette.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(hskupin)
Whiteboard: [checkin-needed-beta][checkin-needed-esr52]
You need to log in before you can comment on or make changes to this bug.