1378251 - Windows taskcluster builds fail to upload minidump artifacts

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

As seen in bug 1338878, if a Windows taskcluster build selftest crashes and a minidump is produced, the .dmp and .extra files are not uploaded as artifacts.

It looks like the MINIDUMP_SAVE_PATH is out of sync with the upload path.

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: update MINIDUMP_SAVE_PATH for windows taskcluster builds

This is just a one-line change applied repeatedly to each windows tc build config.

The crashes in https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eb4a4ebb7124613283dfbfb16d57016df6df429 confirm that the change works: .dmp and .extra artifacts are produced.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8883626 [details] [diff] [review]
update MINIDUMP_SAVE_PATH for windows taskcluster builds

Review of attachment 8883626 [details] [diff] [review]:
-----------------------------------------------------------------

Fun. I also noticed recently that builds still use the minidump_stackwalk binary from the build/tools repo. It'd be nice to make them use the same one we use for tests, since that one has some nicer features, like fetching system symbols from the symbol server.

Comment 3

[Geoff Brown [:gbrown] (pto Apr 11-18)]

I know the ubuntu docker images for tests include minidump_stackwalk, such as:

https://dxr.mozilla.org/mozilla-central/rev/211d4dd61025c0a40caea7a54c9066e051bdde8c/taskcluster/docker/recipes/ubuntu1604-test-system-setup.sh#135

and I know some test jobs pull from tooltool, using, for instance:

https://dxr.mozilla.org/mozilla-central/rev/211d4dd61025c0a40caea7a54c9066e051bdde8c/testing/config/tooltool-manifests/win32/releng.manifest

but I don't quite see where builds get it from.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f897e328d8aa
Upload Windows TC build crash dumps as artifacts; r=ted

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f897e328d8aa

Comment 6

[(not currently active) Ted Mielczarek]

(In reply to Geoff Brown [:gbrown] from comment #3)
> I know the ubuntu docker images for tests include minidump_stackwalk, such
> as:
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> 211d4dd61025c0a40caea7a54c9066e051bdde8c/taskcluster/docker/recipes/
> ubuntu1604-test-system-setup.sh#135
> 
> and I know some test jobs pull from tooltool, using, for instance:
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> 211d4dd61025c0a40caea7a54c9066e051bdde8c/testing/config/tooltool-manifests/
> win32/releng.manifest

Right, those both pull the newer version I was talking about.

> but I don't quite see where builds get it from.

I started typing a long comment, then decided I should file a new bug instead: bug 1378765

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e1a61116ca15