Closed Bug 1378251 Opened 5 years ago Closed 5 years ago
Windows taskcluster builds fail to upload minidump artifacts
As seen in bug 1338878, if a Windows taskcluster build selftest crashes and a minidump is produced, the .dmp and .extra files are not uploaded as artifacts. It looks like the MINIDUMP_SAVE_PATH is out of sync with the upload path.
This is just a one-line change applied repeatedly to each windows tc build config. The crashes in https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eb4a4ebb7124613283dfbfb16d57016df6df429 confirm that the change works: .dmp and .extra artifacts are produced.
Attachment #8883626 - Flags: review?(ted)
Comment on attachment 8883626 [details] [diff] [review] update MINIDUMP_SAVE_PATH for windows taskcluster builds Review of attachment 8883626 [details] [diff] [review]: ----------------------------------------------------------------- Fun. I also noticed recently that builds still use the minidump_stackwalk binary from the build/tools repo. It'd be nice to make them use the same one we use for tests, since that one has some nicer features, like fetching system symbols from the symbol server.
Attachment #8883626 - Flags: review?(ted) → review+
I know the ubuntu docker images for tests include minidump_stackwalk, such as: https://dxr.mozilla.org/mozilla-central/rev/211d4dd61025c0a40caea7a54c9066e051bdde8c/taskcluster/docker/recipes/ubuntu1604-test-system-setup.sh#135 and I know some test jobs pull from tooltool, using, for instance: https://dxr.mozilla.org/mozilla-central/rev/211d4dd61025c0a40caea7a54c9066e051bdde8c/testing/config/tooltool-manifests/win32/releng.manifest but I don't quite see where builds get it from.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f897e328d8aa Upload Windows TC build crash dumps as artifacts; r=ted
(In reply to Geoff Brown [:gbrown] from comment #3) > I know the ubuntu docker images for tests include minidump_stackwalk, such > as: > > https://dxr.mozilla.org/mozilla-central/rev/ > 211d4dd61025c0a40caea7a54c9066e051bdde8c/taskcluster/docker/recipes/ > ubuntu1604-test-system-setup.sh#135 > > and I know some test jobs pull from tooltool, using, for instance: > > https://dxr.mozilla.org/mozilla-central/rev/ > 211d4dd61025c0a40caea7a54c9066e051bdde8c/testing/config/tooltool-manifests/ > win32/releng.manifest Right, those both pull the newer version I was talking about. > but I don't quite see where builds get it from. I started typing a long comment, then decided I should file a new bug instead: bug 1378765
You need to log in before you can comment on or make changes to this bug.