Closed
Bug 1378252
Opened 7 years ago
Closed 7 years ago
Enable funsize for TC osx builds/repacks
Categories
(Release Engineering :: General, enhancement)
Release Engineering
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(4 files)
59 bytes,
text/x-review-board-request
|
Callek
:
review+
|
Details |
49 bytes,
text/x-github-pull-request
|
sfraser
:
review+
rail
:
checked-in+
|
Details | Review |
59 bytes,
text/x-review-board-request
|
sfraser
:
review+
rail
:
checked-in+
|
Details |
49 bytes,
text/x-github-pull-request
|
rail
:
review+
|
Details | Review |
Mac builds are generated by TC and there are some differences versus TC linux builds/repacks: 1) complete.mar files are generated in repackage-signing tasks (vs build-signing on linux). The tasks should be "marked" as funsize tasks. 2) repackage-signing has more than one dependency. The funsize scheduler should find the "build" task, which contains gecko revision info and balrog_props.json
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8883426 -
Flags: review?(sfraser)
Updated•7 years ago
|
Attachment #8883426 -
Flags: review?(sfraser) → review+
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8883571 [details] Bug 1378252 - Bump funsize version https://reviewboard.mozilla.org/r/154510/#review159578
Attachment #8883571 -
Flags: review?(sfraser) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8883571 [details] Bug 1378252 - Bump funsize version remote: https://hg.mozilla.org/build/puppet/rev/fbb2e545b1ab468416beb1adc9da53bd065fd7bd remote: https://hg.mozilla.org/build/puppet/rev/639e8b9f155361d7362598f8b614e7373c0568fb
Attachment #8883571 -
Flags: checked-in+
Assignee | ||
Comment 6•7 years ago
|
||
I pushed the gecko patch to date and see that it added the funsize routes to the repackage-signing: https://tools.taskcluster.net/groups/F1l5rESnQuyq_dfByEkGIw/tasks/d35sjkN8Qy-i_Vi8S-i2VQ/details
Assignee | ||
Updated•7 years ago
|
Attachment #8883426 -
Flags: checked-in+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8883425 [details] Bug 1378252 - Add funsize routes to mac repackage-signing tasks https://reviewboard.mozilla.org/r/154326/#review159640
Attachment #8883425 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Attachment #8883425 -
Flags: review?(sfraser)
Comment hidden (mozreview-request) |
Pushed by raliiev@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/901825f49b23 Add funsize routes to mac repackage-signing tasks r=Callek
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/901825f49b23
Assignee | ||
Comment 11•7 years ago
|
||
Founds some issues with the approach in funsize: Jul 06 05:46:53 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler 2017-07-06 05:46:53,019 - funsize.worker - INFO - Looking for gecko revision in [u'CVtHJjsxQ-KfB9gNO8ZYAA', u'Pr9OcxSqQlOjbytRDpHd2g', u'A5DOS37gQY-LF8my_o1uog', u'Z10ewJaRQVqwH3Wi0bIKsA', u'OHtVs_KZRq2--lrJbc2biw'] Jul 06 05:46:53 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler 2017-07-06 05:46:53,298 - funsize.worker - INFO - skipping CVtHJjsxQ-KfB9gNO8ZYAA Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler 2017-07-06 05:46:54,777 - funsize.worker - ERROR - Failed to process message Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler Traceback (most recent call last): Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler File "/builds/funsize/lib/python2.7/site-packages/funsize/worker.py", line 343, in process_message Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler self.dispatch_message(body, message) Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler File "/builds/funsize/lib/python2.7/site-packages/funsize/worker.py", line 367, in dispatch_message Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler gdata = parse_taskcluster_message(message.payload) Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler File "/builds/funsize/lib/python2.7/site-packages/funsize/worker.py", line 110, in parse_taskcluster_message Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler 'artifacts'] if 'balrog_props.json' in a['name']) Jul 06 05:46:54 buildbot-master94.bb.releng.use1.mozilla.com python: funsize_scheduler StopIteration Jul 06 05:47:16 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler 2017-07-06 05:47:16,708 - funsize.worker - INFO - Looking for gecko revision in [u'Pr9OcxSqQlOjbytRDpHd2g', u'OHtVs_KZRq2--lrJbc2biw', u'dQ0E0_YlTJW5vqyfkIRXCQ', u'CVtHJjsxQ-KfB9gNO8ZYAA', u'Z10ewJaRQVqwH3Wi0bIKsA'] Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler 2017-07-06 05:47:18,682 - funsize.worker - ERROR - Failed to process message Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler Traceback (most recent call last): Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler File "/builds/funsize/lib/python2.7/site-packages/funsize/worker.py", line 343, in process_message Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler self.dispatch_message(body, message) Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler File "/builds/funsize/lib/python2.7/site-packages/funsize/worker.py", line 367, in dispatch_message Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler gdata = parse_taskcluster_message(message.payload) Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler File "/builds/funsize/lib/python2.7/site-packages/funsize/worker.py", line 110, in parse_taskcluster_message Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler 'artifacts'] if 'balrog_props.json' in a['name']) Jul 06 05:47:18 buildbot-master91.bb.releng.usw2.mozilla.com python: funsize_scheduler StopIteration
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 12•7 years ago
|
||
Looks like GECKO_HEAD_REV is not enough by itself, the task artifacts also should contain balrog_props.json as well
Assignee | ||
Comment 13•7 years ago
|
||
Attachment #8883935 -
Flags: review?(sfraser)
Assignee | ||
Comment 14•7 years ago
|
||
Comment on attachment 8883935 [details] [review] Funsize scheduler PR #2 r+ed in the PR
Attachment #8883935 -
Flags: review?(sfraser) → review+
Assignee | ||
Comment 15•7 years ago
|
||
remote: https://hg.mozilla.org/build/puppet/rev/6046a99499ae578045d18ddc309f9f4980d8b683 remote: https://hg.mozilla.org/build/puppet/rev/1658e177581e6de35aa698c88043356b569e20de
Assignee | ||
Comment 16•7 years ago
|
||
Looks like we got some partials!
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•