Closed Bug 1378387 Opened 7 years ago Closed 7 years ago

use dependent strings in the url-classifier where possible

Categories

(Toolkit :: Safe Browsing, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

Doing this makes various operations more efficient, as we don't have to
allocate, copy strings, and deallocate needlessly.  The remaining
instances of nsCString temporaries are in logging code, which didn't
seem worthwhile to deal with here.
Feel free to pass this review on if you like.
Attachment #8883577 - Flags: review?(gpascutto)
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #8883577 - Flags: review?(gpascutto) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/307b2cc53ba8
use dependent strings in the url-classifier where possible; r=gcp
https://hg.mozilla.org/mozilla-central/rev/307b2cc53ba8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: