Closed
Bug 1378387
Opened 7 years ago
Closed 7 years ago
use dependent strings in the url-classifier where possible
Categories
(Toolkit :: Safe Browsing, enhancement, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
3.96 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
Doing this makes various operations more efficient, as we don't have to allocate, copy strings, and deallocate needlessly. The remaining instances of nsCString temporaries are in logging code, which didn't seem worthwhile to deal with here.
Assignee | ||
Comment 1•7 years ago
|
||
Feel free to pass this review on if you like.
Attachment #8883577 -
Flags: review?(gpascutto)
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Updated•7 years ago
|
Attachment #8883577 -
Flags: review?(gpascutto) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/307b2cc53ba8 use dependent strings in the url-classifier where possible; r=gcp
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/307b2cc53ba8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•