Indicate that packages currently only support Python 2

RESOLVED FIXED in Firefox 57

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: davehunt, Assigned: saisarathganti, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Version 3
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment, 4 obsolete attachments)

Until bug 1093212 is resolved, we should update the trove classifiers [1] for all mozbase packages to indicate that they only support Python 2. As the change is trivial, I think it would be fine to accept patches for all mozbase packages against this bug. We should add the following classifiers if not already present:

Programming Language :: Python :: 2.7
Programming Language :: Python :: 2 :: Only

The packages can all be found in the directories within https://dxr.mozilla.org/mozilla-central/source/testing/mozbase. Each has a setup.py where the above classifiers should be added. Once updated, we should probably also version bump and release new versions of each package.

[1] https://pypi.python.org/pypi?%3Aaction=list_classifiers
Assignee

Comment 1

2 years ago
Hi,
I am a beginner.can you please guide me to work on this bug.This is my first bug.I have just built firefox.
Assignee

Comment 2

2 years ago
can you tell me where to start
(In reply to sharu from comment #2)
> can you tell me where to start

Hi Sharu, thanks for your interest in this bug! To get started you will need to clone the mozilla-central repository. You should then be able to find the setup.py files referenced in comment 0 and make the necessary changes. You should then run the tests to make sure nothing has regressed. The Contributing to the Mozilla code base (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction) guide should provide you with all the information you need. You don't need to build Firefox to work on this bug, though.
Assignee

Comment 4

2 years ago
hi,
can you tell me how to run the test.
Assignee

Comment 5

2 years ago
kindly tell me what is version bump.
Assignee

Comment 6

2 years ago
kindly tell me how to version bump
Assignee

Comment 7

2 years ago
Hi,by what number should i version bump i.e 0.1(minor) or 1.0.
I am very much new to this field.
Assignee

Comment 8

2 years ago
Posted patch bug1378422.patch (obsolete) — Splinter Review
Attachment #8889135 - Flags: review?
Attachment #8889135 - Flags: feedback?
Assignee

Updated

2 years ago
Attachment #8889135 - Flags: review?(ahalberstadt)
Attachment #8889135 - Flags: review?
Attachment #8889135 - Flags: feedback?
Comment on attachment 8889135 [details] [diff] [review]
bug1378422.patch

Review of attachment 8889135 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Sharu, you can run the tests like this:
./mach python-test testing/mozbase

I'd say lets not worry about a version bump just for this (we can leave it until these packages have some other substantial change that requires a bump). Your patch is on the right track, but you need to keep the indentation level otherwise this will fail the lint check. You can run the linter yourself with:
./mach lint --outgoing (to lint the changes in your patch)

or
./mach lint testing/mozbase (to lint a specific directory)

It also looks like you missed the 'testing/mozbase/mozlog' module. Please fix these issues and submit a new patch, thanks for your work!
Attachment #8889135 - Flags: review?(ahalberstadt)
Assignee

Comment 10

2 years ago
Posted patch bug1378422.patch (obsolete) — Splinter Review
this is my new patch file.Sorry for late response.
Attachment #8895417 - Flags: review?(ahalberstadt)
Comment on attachment 8895417 [details] [diff] [review]
bug1378422.patch

Review of attachment 8895417 [details] [diff] [review]:
-----------------------------------------------------------------

Hi sharu, thanks for the patch. But it looks like it is only modifying testing/firefox-ui/harness/setup.py. We'd like to add this for all the setup.py files under testing/mozbase in this bug.
Attachment #8895417 - Flags: review?(ahalberstadt)
Assignee

Comment 12

2 years ago
Posted patch bug1378422.patch (obsolete) — Splinter Review
sorry i have actually not checked the patch file. I have committed twice and created only the last committed patch file using command "hg export -r.>~/bug1378422" but this time i have pasted the previous committed patch file also.
Attachment #8896624 - Flags: review?(ahalberstadt)
Comment on attachment 8896624 [details] [diff] [review]
bug1378422.patch

Review of attachment 8896624 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks sharu, this fixes the issue! But this is an interdiff from your earlier patch, we'll need you to upload the full patch all at once before we can land it. You can try using 'hg histedit' to fold your commits into one big commit, then you can export it with 'hg export'. You'll also need to modify the commit message, it should be of the form:
Bug 1378422 - <message>, r=ahal

For more details, see:
https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Thanks again!
Attachment #8896624 - Flags: review?(ahalberstadt) → feedback+
Assignee: nobody → saisarathganti
Status: NEW → ASSIGNED
Assignee

Comment 14

2 years ago
Posted patch Bug1378422.patch (obsolete) — Splinter Review
Does this satisfy all the conditions??thanks
Attachment #8898898 - Flags: review?(ahalberstadt)
Comment on attachment 8898898 [details] [diff] [review]
Bug1378422.patch

Review of attachment 8898898 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Sharu, sorry I think you misunderstood. You need to collapse all your patches into a single patch that has every change in it. I'm not sure what version control system, but if you are using mercurial without mq, you could look into `hg histedit` to accomplish that.

No matter how you accomplish it, at the end there should be a single bugzilla attachment that contains all the changes you made.
Attachment #8898898 - Flags: review?(ahalberstadt) → review-
Assignee

Comment 16

2 years ago
I have just folded all the commits into one commit.is this correct?.thank you soo much for helping me.
Attachment #8901536 - Flags: review?(ahalberstadt)
Comment on attachment 8901536 [details] [diff] [review]
Bug1378422.patch

Review of attachment 8901536 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks sharu, this looks great! I'll land it for you.
Attachment #8901536 - Flags: review?(ahalberstadt) → review+
Attachment #8898898 - Attachment is obsolete: true
Attachment #8889135 - Attachment is obsolete: true
Attachment #8896624 - Attachment is obsolete: true
Attachment #8895417 - Attachment is obsolete: true

Comment 18

2 years ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4322e848dd0
Add python 2 only classifiers to python modules under /testing, r=ahal
https://hg.mozilla.org/mozilla-central/rev/b4322e848dd0
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Awesome, thanks sharu! If you're interested in helping us to move to Python 3 support please take a look at bug 1093212 and its dependencies.
You need to log in before you can comment on or make changes to this bug.