Closed Bug 1378449 Opened 5 years ago Closed 5 years ago

Surface the most common JavaScript errors.

Categories

(DevTools :: Console, enhancement)

enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: nbp, Assigned: nbp)

Details

Attachments

(1 file)

This bug is about taking over the telemetry added by Morgan in Bug 1255133.

I agree that the overview of the probe from the telemetry website is not useful,
as stated by Bug 1255133 comment 21.  In order to present the data in a useful way, I made the following page:

https://nbp.github.io/arewedocumentedyet/

I will fix the issue reported in Bug 1255133 comment 21, and bump the version for the telemetry.
(In reply to Georg Fritzsche [:gfritzsche] from comment #28)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #27)
> > It seems weird that we require a keyed histogram for this instead of an
> > enumeration
> 
> Morgan, can we move this to an enumerated (non-keyed) histogram in a
> follow-up bug?

Using an enumerated histogram would add constraints that are not enforced
anywhere in the code, and adding this constraint would involve way more
changes.

Now, the name (= key) of the error message is currently used both in the
code, and in the devtools.

Reporting keyed historgram might be slower (as stated in the documentation),
but this should not matter much as these are responses to the user in the
console of the devtools.
Attachment #8883663 - Flags: review?(mratcliffe)
Attachment #8883663 - Flags: feedback?(benjamin)
Attachment #8883663 - Flags: review?(mratcliffe) → review+
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43e0e2747b9b
Revive DEVTOOLS_JAVASCRIPT_ERROR_DISPLAYED telemetry probe. r=miker
https://hg.mozilla.org/mozilla-central/rev/43e0e2747b9b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Did this data collection change receive Data Collection Review? https://wiki.mozilla.org/Firefox/Data_Collection
Flags: needinfo?(nicolas.b.pierron)
(In reply to Chris H-C :chutten from comment #4)
> Did this data collection change receive Data Collection Review?
> https://wiki.mozilla.org/Firefox/Data_Collection

Apparently not, and I apologize as this was not my intent as I chose the previous reviewers of the patch.

I already asked :bsmedberg for feedback, and I can backout/fix based on the reply.  Except for the description, which should fix the previous complains, the only difference is for bumping the expiring version number to "never".

This data is useful to track of the error messages which have to be documented, or separated within the code base, as you can see on https://nbp.github.io/arewedocumentedyet/ .  I already opened multiple bugs based on the result of this telemetry, and these pages are apparently a huge source of organic traffic to MDN.
Flags: needinfo?(nicolas.b.pierron)
Comment on attachment 8883663 [details] [diff] [review]
Revive DEVTOOLS_JAVASCRIPT_ERROR_DISPLAYED telemetry probe.

data-review with the following notes and followup from IRC:

* nbp will add his email address back to alert_emails
* I recommend but do not require that this be made opt-out, to see how this behaves with release users

The long-term value is prioritizing and validating documentation, and nbp is using a monthly report to do that and takes responsibility for the long-term maintenance of this metric.
Attachment #8883663 - Flags: feedback?(benjamin) → feedback+
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d56f610f9e12
Add missing alert_email for DEVTOOLS_JAVASCRIPT_ERROR_DISPLAYED telemetry probe. data-r=bsmedberg
Assignee: nobody → nicolas.b.pierron
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.