1378465 - newtab tour items change offset on completion

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Tomer Cohen :tomer]

Attachment: tour animation

When completing a task on the newtab tour, the task title gets a green completion badge. As a side effect, the items below gets down by about a pixel. 

Actual result: Please see attached animation.

Last good revision: 22017d54ba07b285e2c258b3031091f38775a72d
First bad revision: 3a2a088b9465856f4de98847490b5b871476d4bd
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=22017d54ba07b285e2c258b3031091f38775a72d&tochange=3a2a088b9465856f4de98847490b5b871476d4bd

Comment 1

[Tomer Cohen :tomer]

Attachment: Suggested change (visual)

(In reply to Tomer Cohen :tomer from comment #0)
> down by about a pixel. 

Six pixels, to be exact. 

Dimensions of incomplete task: 214px × 45px
Dimensions of completed task:  214px × 51px

I can fix it by adding a float:inline-start rule, but while it looks pretty on RTL, it does overlap the text on LTR.

Comment 2

[Tomer Cohen :tomer]

Attachment: Bug 1378465 - newtab tour items change offset on completion

Review commit: https://reviewboard.mozilla.org/r/154628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154628/

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks for helping out!

Comment 4

[[e-mail]]

Comment on attachment 8883823 [details]
Bug 1378465 - newtab tour items change offset on completion

https://reviewboard.mozilla.org/r/154628/#review159824

thanks for the patch! 1 nit for rtl improvement

::: browser/extensions/onboarding/content/onboarding.css:138
(Diff revision 1)
>  }
>  
>  #onboarding-tour-list > li.onboarding-complete::before {
>    content: url("img/icons_tour-complete.svg");
>    position: relative;
>    left: 6px;

can change `left: 6px` to `offset-inline-start: 3px;` then rtl will works fine as well

Comment 5

[Tomer Cohen :tomer]

Comment on attachment 8883823 [details]
Bug 1378465 - newtab tour items change offset on completion

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154628/diff/1-2/

Comment 6

[[e-mail]]

Comment on attachment 8883823 [details]
Bug 1378465 - newtab tour items change offset on completion

https://reviewboard.mozilla.org/r/154628/#review160122

LGTM, thanks!

Comment 7

[Carsten Book [:Tomcat]]

need a suitable reviewer still it seems, can you fix this so we can use autoland ? thanks

Comment 8

[[e-mail]]

Hi tomer, you still need mossop's stamp so the autoland will work

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 8883823 [details]
Bug 1378465 - newtab tour items change offset on completion

https://reviewboard.mozilla.org/r/154628/#review160326

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b5a7ee81d81
newtab tour items change offset on completion r=gasolin,mossop

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7b5a7ee81d81

Comment 12

[Md.Tarikul Islam Oashi]

I have reproduced this bug with nightly 56.0a1 (2017-07-05) on Linux Mint (64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1

Build ID 	20170714100217
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0