1378537 - Store performance objects in an AutoTArray to speed up marking

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Right now we store marks/measures in nsTArray, meaning we're allocating per mark/measure. Use AutoTArray to give this a performance bump.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1378537 - Store PerformanceEntry objects in AutoTArray;

Storing PerformanceEntry objects in an AutoTArray (currently sized to
match our limit for resource timing entries) should omit some
per-entry allocations and give us a small speedup with creating
entries in tight loops.

Review commit: https://reviewboard.mozilla.org/r/154646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154646/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8883736 [details]
Bug 1378537 - Store PerformanceEntry objects in AutoTArray;

https://reviewboard.mozilla.org/r/154646/#review159896

Arrays are quite large, but at least they are per document only.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8883736 [details]
Bug 1378537 - Store PerformanceEntry objects in AutoTArray;

https://reviewboard.mozilla.org/r/154646/#review159898

::: dom/performance/Performance.h:155
(Diff revision 1)
>    DOMHighResTimeStamp RoundTime(double aTime) const;
>  
>    nsTObserverArray<PerformanceObserver*> mObservers;
>  
>  private:
> -  nsTArray<RefPtr<PerformanceEntry>> mUserEntries;
> +  static const uint64_t kDefaultResourceTimingBufferSize = 150;

Could you add a comment somewhere here that if and when the limit is increased, this code should probably move to use SegmentedVector

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8883736 [details]
Bug 1378537 - Store PerformanceEntry objects in AutoTArray;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154646/diff/1-2/

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8883736 [details]
Bug 1378537 - Store PerformanceEntry objects in AutoTArray;

https://reviewboard.mozilla.org/r/154646/#review159990

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ee991439579
Store PerformanceEntry objects in AutoTArray; r=smaug

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ee991439579