Closed
Bug 1378540
Opened 7 years ago
Closed 7 years ago
stylo: Rip out the generic abstractions around ThreadLocalStyleContext
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
30.14 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
These keep getting in the way and aren't actually necessary for layout anymore.
|
Assignee | |
Comment 1•7 years ago
|
||
MozReview-Commit-ID: 5WTLuk323Ac
Attachment #8883733 -
Flags: review?(emilio+bugs)
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=75454cb10e3cb9c7878eb0f1862b43eea082cb8a
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8883733 [details] [diff] [review] Rip out the generic abstractions around ThreadLocalStyleContext. v1 Review of attachment 8883733 [details] [diff] [review]: ----------------------------------------------------------------- Nice! r=me ::: servo/components/style/traversal.rs @@ +468,5 @@ > &parent.borrow_data().unwrap(), > MayLog > ); > > + context.thread_local.borrow_mut().end_element(parent); nit: do you need these borrow_mut() now?
Attachment #8883733 -
Flags: review?(emilio+bugs) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://github.com/servo/servo/pull/17615
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•