stylo: Rip out the generic abstractions around ThreadLocalStyleContext

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: Bobby Holley (parental leave - send mail for anything urgent), Assigned: Bobby Holley (parental leave - send mail for anything urgent))

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

These keep getting in the way and aren't actually necessary for layout anymore.
Created attachment 8883733 [details] [diff] [review]
Rip out the generic abstractions around ThreadLocalStyleContext. v1

MozReview-Commit-ID: 5WTLuk323Ac
Attachment #8883733 - Flags: review?(emilio+bugs)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=75454cb10e3cb9c7878eb0f1862b43eea082cb8a
Comment on attachment 8883733 [details] [diff] [review]
Rip out the generic abstractions around ThreadLocalStyleContext. v1

Review of attachment 8883733 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me

::: servo/components/style/traversal.rs
@@ +468,5 @@
>                  &parent.borrow_data().unwrap(),
>                  MayLog
>              );
>  
> +        context.thread_local.borrow_mut().end_element(parent);

nit: do you need these borrow_mut() now?
Attachment #8883733 - Flags: review?(emilio+bugs) → review+
https://github.com/servo/servo/pull/17615
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.