1378543 - Update webrender_bindings for cbindgen:0.1.13

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

I was thinking of combining the cbindgen update along with an update to use euclid types, but that's waiting on the webrender update, which might take a while.

I'd like to just do the cbindgen update (which includes a CLI change) so that crates.io won't be so far behind.

The new invocation is `cbindgen toolkit/library/rust/ --crate webrender_bindings -o gfx/webrender_bindings/webrender_ffi_geneerated.h`. I'll send an email to dev.tech.gfx with this when this lands.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1378543 - Update webrender_bindings for cbindgen:0.1.13.

Review commit: https://reviewboard.mozilla.org/r/154642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154642/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8883735 [details]
Bug 1378543 - Update webrender_bindings for cbindgen:0.1.13.

https://reviewboard.mozilla.org/r/154642/#review159902

::: gfx/webrender_bindings/webrender_ffi_generated.h:9
(Diff revision 1)
>  
> -/* Generated with cbindgen:0.1.10 */
> +/* Generated with cbindgen:0.1.13 */
>  
>  /* DO NOT MODIFY THIS MANUALLY! This file was generated using cbindgen.
>   * To generate this file, clone `https://github.com/rlhunt/cbindgen` or run `cargo install cbindgen`,
>   * then run `cbindgen gfx/webrender_bindings/ -o gfx/webrender_bindings/webrender_ffi_generated.h` */

Shouldn't this line change as well to reflect the new CLI command?

Comment 3

[Ryan Hunt [:rhunt]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Comment on attachment 8883735 [details]
> Bug 1378543 - Update webrender_bindings for cbindgen:0.1.13.
> 
> https://reviewboard.mozilla.org/r/154642/#review159902
> 
> ::: gfx/webrender_bindings/webrender_ffi_generated.h:9
> (Diff revision 1)
> >  
> > -/* Generated with cbindgen:0.1.10 */
> > +/* Generated with cbindgen:0.1.13 */
> >  
> >  /* DO NOT MODIFY THIS MANUALLY! This file was generated using cbindgen.
> >   * To generate this file, clone `https://github.com/rlhunt/cbindgen` or run `cargo install cbindgen`,
> >   * then run `cbindgen gfx/webrender_bindings/ -o gfx/webrender_bindings/webrender_ffi_generated.h` */
> 
> Shouldn't this line change as well to reflect the new CLI command?

Ah yes, I forgot to update that. I will also update the message to only mention using `cargo install` as I've been using that for stable releases. Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec23aa9d24c6
Update webrender_bindings for cbindgen:0.1.13. r=kats

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec23aa9d24c6