Closed Bug 137857 Opened 20 years ago Closed 20 years ago

Move HandleNumbers from nsBidiPresUtils to nsBidiUtils

Categories

(Core :: Layout: Text and Fonts, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

References

Details

Attachments

(1 file)

This is part of the groundwork for bug 99823. HandleNumbers should really have
already been moved to nsBidiUtils in bug 120818, but I missed it.
Blocks: 99823
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
ftang, can you review?
why we want to move it? what is the benefit of moving it ?
what will it block if we don't move it ?
Moving this enables us to convert Arabic numerals to Indic and vice versa
without needing an nsBidiPresUtils object. It blocks the changes to
nsTextTransformer.cpp in attachment 77103 [details] [diff] [review] (in bug 99823) which I will shortly be
attaching to bug 138097 as a separate attachment.
Comment on attachment 79538 [details] [diff] [review]
Patch

r=ftang looks like straight forward code moving
Attachment #79538 - Flags: review+
Comment on attachment 79538 [details] [diff] [review]
Patch

sr=attinasi
Attachment #79538 - Flags: superreview+
Fix checked in.
Really marking FIXED this time.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.