Return unknown codec instead of error

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ayang, Assigned: ayang)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
In mp4 rust parser, it uses to return an error when parsing unknown box in audio_sample_entry and video_sample_entry. We should reutrn CodecType::Unknown and SampleEntry::Unknown.
So we can get rid of bugs like bug 1372838 and bug 1374194.
(Assignee)

Updated

a year ago
Blocks: 1161350
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8883811 [details]
Bug 1378607 - skip unknown codec type.

https://reviewboard.mozilla.org/r/154766/#review160088

Does it make sense to circle back and remove AC3/EAC3/JPEG and any others we added before taking this approach?
Attachment #8883811 - Flags: review?(kinetik) → review+
(Assignee)

Comment 4

a year ago
(In reply to Matthew Gregan [:kinetik] from comment #3)
> Comment on attachment 8883811 [details]
> Bug 1378607 - skip unknown codec type.
> 
> https://reviewboard.mozilla.org/r/154766/#review160088
> 
> Does it make sense to circle back and remove AC3/EAC3/JPEG and any others we
> added before taking this approach?

Yes, I'm thinking to remove the codes in mp4parse_cap, so it returns unknown codecs for ac3/ec3/jpeg in mp4parse_get_track_info(). I'll file another bug for this.
(Assignee)

Updated

a year ago
See Also: → bug 1379047
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8884144 [details]
Bug 1378607 - update rust mp4 parser.

https://reviewboard.mozilla.org/r/155066/#review160124
Attachment #8884144 - Flags: review?(kinetik) → review+

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/22cec1837059
https://hg.mozilla.org/mozilla-central/rev/bed1180449df
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.