1378689 - Add a structure to pack the data sent to the MediaDecoderReader constructor

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

It would be handy when we want to send more data to the constructor.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1378689 - add a structure to pack the data sent to the MediaDecoderReader constructor.

It would be handy we want to pass more data to the constructor.

Review commit: https://reviewboard.mozilla.org/r/155110/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155110/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8884183 [details]
Bug 1378689 - add a structure to pack the data sent to the MediaDecoderReader constructor.

https://reviewboard.mozilla.org/r/155110/#review160172

::: dom/media/DecoderTraits.h:55
(Diff revision 1)
>      DecoderDoctorDiagnostics* aDiagnostics);
>  
>    // Create a reader for thew given MIME type aType. Returns null
>    // if we were unable to create the reader.
>    static MediaDecoderReader* CreateReader(const MediaContainerType& aType,
> -                                          AbstractMediaDecoder* aDecoder,
> +                                          MediaDecoderReaderInit& aInit);

MediaDecoderReaderInit only contains pointer and is never modified (nor do I see the need for it now or in the future)

so please make all of those constructors use const MediaDecoderReaderInit& instead.

::: dom/media/DecoderTraits.cpp:355
(Diff revision 1)
>    }
>  
>  #ifdef MOZ_FMP4
>    if (MP4Decoder::IsSupportedType(aType,
>                                    /* DecoderDoctorDiagnostics* */ nullptr)) {
> -    decoderReader = new MediaFormatReader(aDecoder, new MP4Demuxer(aResource));
> +    decoderReader = new MediaFormatReader(aInit, new MP4Demuxer(resource));

I'd prefer to drop the temp variable and use aInit.mResource everywhere

::: dom/media/MediaDecoderReader.h:71
(Diff revision 1)
> +{
> +  AbstractMediaDecoder* const mDecoder;
> +  MediaResource* mResource = nullptr;
> +  VideoFrameContainer* mVideoFrameContainer = nullptr;
> +
> +  explicit MediaDecoderReaderInit(AbstractMediaDecoder* aDecoder)

didn't you remove AbstractMediaDecoder* ?

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8884183 [details]
Bug 1378689 - add a structure to pack the data sent to the MediaDecoderReader constructor.

https://reviewboard.mozilla.org/r/155110/#review160172

> I'd prefer to drop the temp variable and use aInit.mResource everywhere

It will make line-breaking ugly for it slightly exceed the 80-cols limit.

> didn't you remove AbstractMediaDecoder* ?

We will. But for now we still have AndroidMediaReader which accesses AbstractMediaDecoder.

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8884183 [details]
Bug 1378689 - add a structure to pack the data sent to the MediaDecoderReader constructor.

https://reviewboard.mozilla.org/r/155110/#review160182

::: dom/media/DecoderTraits.cpp:355
(Diff revision 1)
>    }
>  
>  #ifdef MOZ_FMP4
>    if (MP4Decoder::IsSupportedType(aType,
>                                    /* DecoderDoctorDiagnostics* */ nullptr)) {
> -    decoderReader = new MediaFormatReader(aDecoder, new MP4Demuxer(aResource));
> +    decoderReader = new MediaFormatReader(aInit, new MP4Demuxer(resource));

at least only declare it below the test then, otherwise it's unused.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8884183 [details]
Bug 1378689 - add a structure to pack the data sent to the MediaDecoderReader constructor.

https://reviewboard.mozilla.org/r/155110/#review160182

> at least only declare it below the test then, otherwise it's unused.

The |if (!aInit.mDecoder)| test?

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8884183 [details]
Bug 1378689 - add a structure to pack the data sent to the MediaDecoderReader constructor.

https://reviewboard.mozilla.org/r/155110/#review160182

> The |if (!aInit.mDecoder)| test?

yes

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8884183 [details]
Bug 1378689 - add a structure to pack the data sent to the MediaDecoderReader constructor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155110/diff/1-2/

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfe994f2c670
add a structure to pack the data sent to the MediaDecoderReader constructor. r=jya

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dfe994f2c670