Closed Bug 1378703 Opened 7 years ago Closed 7 years ago

Make browser_tab_label_during_restore.js more robust and clean up browser_label_and_icon.js

Categories

(Firefox :: Session Restore, enhancement)

Product:
Firefox
Component:
Session Restore
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Bug 1378703 - Make browser_tab_label_during_restore.js more robust and clean up browser_label_and_icon.js.
59 bytes, text/x-review-board-request
cpeterson
: review+
Details 
      No description provided.
Comment on attachment 8883884 [details]
Bug 1378703 - Make browser_tab_label_during_restore.js more robust and clean up browser_label_and_icon.js.

https://reviewboard.mozilla.org/r/154874/#review160010

LGTM assuming this new test passes in both e10s and disabled-e10s modes.
Comment on attachment 8883884 [details]
Bug 1378703 - Make browser_tab_label_during_restore.js more robust and clean up browser_label_and_icon.js.

https://reviewboard.mozilla.org/r/154876/#review160018
Attachment #8883884 - Flags: review?(cpeterson) → review+
(In reply to Chris Peterson [:cpeterson] from comment #3)
> LGTM assuming this new test passes in both e10s and disabled-e10s modes.

I confirmed that your test changes pass (on my Mac) in both e10s and disabled-e10s modes.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/603eec06815d
Make browser_tab_label_during_restore.js more robust and clean up browser_label_and_icon.js. r=cpeterson
https://hg.mozilla.org/mozilla-central/rev/603eec06815d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: