Closed Bug 1378718 Opened 8 years ago Closed 8 years ago

Remove vestigial support in the FT2 backend for preloading "hidden" data-URL fonts into the user-font cache

Categories

(Core :: Graphics: Text, enhancement)

Product:
Core
Component:
Graphics: Text
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(2 files)

pt 1 - Remove support for pre-loading "hidden" system fonts in gfxFT2FontList, as this was only used for FxOS
20.75 KB, patch
heycam
: review+
Details | Diff | Splinter Review
pt 2 - Remove support for persistently caching omnijar data-URI fonts in the user-font cache
15.57 KB, patch
heycam
: review+
Details | Diff | Splinter Review
No description provided.
Comment on attachment 8883903 [details] [diff] [review] pt 1 - Remove support for pre-loading "hidden" system fonts in gfxFT2FontList, as this was only used for FxOS Review of attachment 8883903 [details] [diff] [review]: ----------------------------------------------------------------- I'm not very familiar with the gfxFT2FontList code, but this looks reasonable.
Attachment #8883903 - Flags: review?(cam) → review+
Comment on attachment 8883904 [details] [diff] [review] pt 2 - Remove support for persistently caching omnijar data-URI fonts in the user-font cache Review of attachment 8883904 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for doing this!
Attachment #8883904 - Flags: review?(cam) → review+
Oh, in the second patch you there are probably a couple of #includes you can remove, too.
So there are, thanks!
(In reply to Cameron McCormack (:heycam) from comment #3) > Comment on attachment 8883903 [details] [diff] [review] > pt 1 - Remove support for pre-loading "hidden" system fonts in > gfxFT2FontList, as this was only used for FxOS One update to this: the local helper function PreloadAsUserFontFaces can also be removed, as its only caller is gone.
https://hg.mozilla.org/integration/mozilla-inbound/rev/48f72b32a36638fe13aaf98583e4a9e768ea2c2f Bug 1378718 - pt 1 - Remove support for pre-loading "hidden" system fonts in gfxFT2FontList, as this was only used for FxOS. r=heycam https://hg.mozilla.org/integration/mozilla-inbound/rev/a3835054a936e40e2970f2924bd3aee984797a2a Bug 1378718 - pt 2 - Remove support for persistently caching omnijar data-URI fonts in the user-font cache. r=heycam
Assignee: nobody → jfkthame
https://hg.mozilla.org/mozilla-central/rev/48f72b32a366 https://hg.mozilla.org/mozilla-central/rev/a3835054a936
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: