Closed Bug 1378762 Opened 2 years ago Closed 2 years ago

Remove 'aSignature' argument from U2FTokenTransport::Register()

Categories

(Core :: DOM: Device Interfaces, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [webauthn])

Attachments

(1 file)

U2FTokenTransport::Register() currently takes an `aSignature` argument that is filled by neither the soft nor the USB token. It seems redundant as the signature is extracted out of `aRegistration` by U2FDecomposeRegistrationResponse().
Summary: Remove 'aSignature' argument U2FTokenTransport::Register() → Remove 'aSignature' argument from U2FTokenTransport::Register()
I wasn't totally sure if that's what we wanted, maybe we'll need this parameter in the future? I'm happy to leave it if that's the case.
Comment on attachment 8883918 [details] [diff] [review]
0001-Bug-1378762-Remove-aSignature-argument-from-U2FToken.patch

Review of attachment 8883918 [details] [diff] [review]:
-----------------------------------------------------------------

You're right, I don't think we need it. That was due to me misreading how this worked when splitting it across processes. Thanks for fixing this!
Attachment #8883918 - Flags: review?(kyle) → review+
Comment on attachment 8883918 [details] [diff] [review]
0001-Bug-1378762-Remove-aSignature-argument-from-U2FToken.patch

Review of attachment 8883918 [details] [diff] [review]:
-----------------------------------------------------------------

I also agree this is some manner of copy/paste error, but I think it was mine, not qdot's. :D r=me, too.
Attachment #8883918 - Flags: review+
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/767a79ebc446
Remove 'aSignature' argument from U2FTokenTransport::Register() r=qDot,jcj
https://hg.mozilla.org/mozilla-central/rev/767a79ebc446
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.