1378762 - Remove 'aSignature' argument from U2FTokenTransport::Register()

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement)

Description

[Tim Taubert [:ttaubert] (inactive)]

U2FTokenTransport::Register() currently takes an `aSignature` argument that is filled by neither the soft nor the USB token. It seems redundant as the signature is extracted out of `aRegistration` by U2FDecomposeRegistrationResponse().

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1378762-Remove-aSignature-argument-from-U2FToken.patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

I wasn't totally sure if that's what we wanted, maybe we'll need this parameter in the future? I'm happy to leave it if that's the case.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8883918 [details] [diff] [review]
0001-Bug-1378762-Remove-aSignature-argument-from-U2FToken.patch

Review of attachment 8883918 [details] [diff] [review]:
-----------------------------------------------------------------

You're right, I don't think we need it. That was due to me misreading how this worked when splitting it across processes. Thanks for fixing this!

Comment 4

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 8883918 [details] [diff] [review]
0001-Bug-1378762-Remove-aSignature-argument-from-U2FToken.patch

Review of attachment 8883918 [details] [diff] [review]:
-----------------------------------------------------------------

I also agree this is some manner of copy/paste error, but I think it was mine, not qdot's. :D r=me, too.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/767a79ebc446
Remove 'aSignature' argument from U2FTokenTransport::Register() r=qDot,jcj

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/767a79ebc446