1378771 - Reduce the minimum painted layer width.

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P5)

Description

[Nicolas Silva [:nical]]

In bug 788411 we made the minimum layer width 64 because of a driver bug on a specific b2g device. This is wasteful when rendering thin layers like scrollbars and with webrender we tend to have a lot more small layers since every checkbox, button, etc. gets its own layer. It think that we can revisit this limit and get it down to, say, pixels. If there is a worry that some old android devices may have the same bug, we could keep the limit on android specifically, although I'd rather just remove it.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Make it 8 pixels.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8883933 [details] [diff] [review]
Make it 8 pixels.

Review of attachment 8883933 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/RotatedBuffer.cpp
@@ +402,5 @@
>    // Set a minimum width to guarantee a minimum size of buffers we
>    // allocate (and work around problems on some platforms with smaller
>    // dimensions).  64 is the magic number needed to work around the
>    // rendering glitch, and guarantees image rows can be SIMD'd for
>    // even r5g6b5 surfaces pretty much everywhere.

This comment needs updating.

Comment 3

[Nicolas Silva [:nical]]

Attachment: Make it 8 pixels.

Oops!

Comment 4

[Jamie Nicol [:jnicol]]

If there is still an issue with minimum texture sizes on some android devices, I think the better fix would be to increase the texture size in TextureImage and adjust the texture coords when compositing. We already do this on some devices for non-POT sized textures.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a156d0d1acf
Reduce the minimum painted layer width down to 8 pixels. r=jrmuizel

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7a156d0d1acf