Closed Bug 1378790 Opened 4 years ago Closed 4 years ago

Keyboard navigation event listeners are not removed when a photonpanelmultiview instance is destroyed

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Iteration:
56.2 - Jul 10
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

Bug 1378790 - Remove keyboard navigation event listeners when a photonpanelmultiview instance is destroyed.
59 bytes, text/x-review-board-request
Gijs
: review+
Details 
I noticed this issue whilst working intensively with temporary panels in bug 1354532: The keyboard event listener would not get released and spit out JS errors all over the place.
Flags: qe-verify-
Comment on attachment 8883953 [details]
Bug 1378790 - Remove keyboard navigation event listeners when a photonpanelmultiview instance is destroyed.

https://reviewboard.mozilla.org/r/154930/#review159928
Attachment #8883953 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bca149aed818
Remove keyboard navigation event listeners when a photonpanelmultiview instance is destroyed. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/bca149aed818
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.