Keyboard navigation event listeners are not removed when a photonpanelmultiview instance is destroyed

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: mikedeboer, Assigned: mikedeboer)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 56
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
I noticed this issue whilst working intensively with temporary panels in bug 1354532: The keyboard event listener would not get released and spit out JS errors all over the place.
Flags: qe-verify-
Comment hidden (mozreview-request)

Comment 2

a month ago
mozreview-review
Comment on attachment 8883953 [details]
Bug 1378790 - Remove keyboard navigation event listeners when a photonpanelmultiview instance is destroyed.

https://reviewboard.mozilla.org/r/154930/#review159928
Attachment #8883953 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 3

a month ago
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bca149aed818
Remove keyboard navigation event listeners when a photonpanelmultiview instance is destroyed. r=Gijs

Comment 4

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bca149aed818
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.