1378793 - ISE when ConnectionError to KS /macros/

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: KumaScript, defect, P3)

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
A user viewed a page that included a KumaScript rendering error

What happened?
==============
They got an ISE 500 error

What should have happened?
==========================
They should see the page with a rendering error, but without the link to the macro source.

Is there anything else we should know?
======================================
Tracked in sentry:

https://sentry.prod.mozaws.net/operations/mdn-prod/issues/620420/

Traceback:

ConnectionError: HTTPConnectionPool(host='localhost', port=9080): Max retries exceeded with url: /macros/ (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7f177e0f2f10>: Failed to establish a new connection: [Errno 111] Connection refused',))
  File "django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "newrelic/hooks/framework_django.py", line 499, in wrapper
    return wrapped(*args, **kwargs)
  File "django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "django/views/decorators/http.py", line 45, in inner
    return func(request, *args, **kwargs)
  File "kuma/core/decorators.py", line 172, in wrapped
    return func(request, *args, **kwargs)
  File "kuma/wiki/decorators.py", line 31, in _added_header
    response = func(request, *args, **kwargs)
  File "kuma/authkeys/decorators.py", line 34, in process
    return func(request, *args, **kwargs)
  File "kuma/wiki/decorators.py", line 107, in process
    return func(request, *args, **kwargs)
  File "django/views/decorators/http.py", line 158, in inner
    response = func(request, *args, **kwargs)
  File "newrelic/api/function_trace.py", line 110, in literal_wrapper
    return wrapped(*args, **kwargs)
  File "kuma/wiki/views/document.py", line 732, in document
    if ks_errors else
  File "kuma/wiki/kumascript.py", line 282, in macro_sources
    response = requests.get(ks_macro_url)
  File "requests/api.py", line 67, in get
    return request('get', url, params=params, **kwargs)
  File "newrelic/api/external_trace.py", line 124, in dynamic_wrapper
    return wrapped(*args, **kwargs)
  File "requests/api.py", line 53, in request
    return session.request(method=method, url=url, **kwargs)
  File "requests/sessions.py", line 468, in request
    resp = self.send(prep, **send_kwargs)
  File "newrelic/api/external_trace.py", line 124, in dynamic_wrapper
    return wrapped(*args, **kwargs)
  File "requests/sessions.py", line 576, in send
    r = adapter.send(request, **kwargs)
  File "requests/adapters.py", line 437, in send
    raise ConnectionError(e, request=request)

Traceback:

Comment 1

[John Whitlock [:jwhitlock]]

The page this happened on is also impacted by bug 1375869

Comment 2

[John Whitlock [:jwhitlock]]

The Italian page now shows a document parsing error instead of an Internal Server error.  However, I think there is a separate issue with ConnectionErrors from the KumaScript server, and handling them gracefully.  Or maybe we don't want to?  In any case, removing dependency.

Comment 3

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.