1378799 - The 'Tracking Protection on/off' slider on about:privatebrowsing page has a brighter color than the Photon spec

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Brindusa Tot, Desktop QA]

Attachment: PB_OnOffTrackingProtectionButton.jpg

[Affected versions]: 
Nightly 56.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Open Firefox and go to about:privatebrowsing
2. Compare the page with the photon specs (https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/229751570_Private_Browsing).


[Expected result]:
 The page should look like the one from specs.

[Actual result]:
 The 'Tracking Protection on/off' slider on the PB page, set to off position, has a different color(brighter) than the one shown in the image from the invisionapp link (https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/229751570_Private_Browsing). Please see the attached screenshot.

Note:
The shape of the ON/OFF slider is a little different - it seems to be shorter and wider.

Comment 1

[Johann Hofmann [:johannh]]

I'm taking this, I need a relaxing task, like adjusting some colors.

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1378799 - Adjust the tracking protection toggle colors and dimensions for Photon.

Review commit: https://reviewboard.mozilla.org/r/159298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159298/

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8888350 [details]
Bug 1378799 - Adjust the tracking protection toggle colors and dimensions for Photon.

https://reviewboard.mozilla.org/r/159298/#review165478

Thanks!

::: browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css:126
(Diff revision 1)
>  
>  .toggle + .toggle-btn {
>    box-sizing: border-box;
>    cursor: pointer;
> -  min-width: 42px;
> -  height: 26px;
> +  min-width: 48px;
> +  height: 27px;

Brindusa remarks in comment 0 that the slider is shorter and wider in the spec, but you're actually increasing the height by 1px. Each time I've attempted this review, the invision link has refused to load, but this looks fine to me so I'm not opening an issue.

Comment 4

[Johann Hofmann [:johannh]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)
> Comment on attachment 8888350 [details]
> Bug 1378799 - Adjust the tracking protection toggle colors and dimensions
> for Photon.
> 
> https://reviewboard.mozilla.org/r/159298/#review165478
> 
> Thanks!
> 
> ::: browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css:126
> (Diff revision 1)
> >  
> >  .toggle + .toggle-btn {
> >    box-sizing: border-box;
> >    cursor: pointer;
> > -  min-width: 42px;
> > -  height: 26px;
> > +  min-width: 48px;
> > +  height: 27px;
> 
> Brindusa remarks in comment 0 that the slider is shorter and wider in the
> spec, but you're actually increasing the height by 1px. Each time I've
> attempted this review, the invision link has refused to load, but this looks
> fine to me so I'm not opening an issue.

True, though I think this was about the general shape and not the exact size. I extracted the image dimensions from the spec and applied them here. :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46246d4a56a1
Adjust the tracking protection toggle colors and dimensions for Photon. r=nhnt11

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46246d4a56a1

Comment 7

[Saddam Hossain]

I have reproduced this Bug on Nightly 56.0a1 (2017-07-06) on Windows 10, 64 bit!

The bug's fix is now verified on latest  Nightly 56.0a1

Build ID    :	20170727100347
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 8

[Farhadur Reja Fahim]

I have reproduced this bug with Nightly 56.0a1 (2017-07-06)on Ubuntu 16.04, 64 bit!

The bug's fix is now verified on latest Nightly  57.0a1 (64-bit).

Build ID 	20170802100302
 User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday 20170802]

Comment 9

[ovidiu boca[:Ovidiu]]

I verified this issue on Mac OS, Windows 10, and Ubuntu 16.04 and I can't reproduce this issue. I will mark this as verified fixed.