accel/ctrl/cmd-k should bring up the search box if it's in the overflow panel post-photon

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Search
P1
normal
VERIFIED FIXED
a month ago
14 days ago

People

(Reporter: catlee, Assigned: Gijs)

Tracking

(Blocks: 1 bug, {regression})

Trunk
Firefox 56
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56 fixed, firefox57 verified)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a month ago
I used to have the search box in the hamburger menu. I was able to use Ctrl-K to pop open the menu, enter my search in the search box, hit enter, and have the search open in a new tab.

At some point the search box disappeared from the hamburger menu, and Ctrl-K now focuses on the address bar.

I can re-add the search box to the overflow panel using the menu customization tool.

However, Ctrl-K does not open the overflow panel.
(Assignee)

Comment 1

a month ago
This is effectively a regression, so I think we just need to make sure we fix it given people do this, especially given the plans to remove the search bar from the default nav-bar configuration.
Keywords: regression
Whiteboard: [photon-structure][triage] → [photon-structure]
(Assignee)

Comment 2

a month ago
bug 1354117 covers moving added items from the hamburger panel into the overflow panel (and vice versa if you flip the pref).

I'll morph this bug to explicitly be about the shortcut.
Depends on: 1354117
Summary: Search box disappears from hamburger menu post-photon → accel/ctrl/cmd-k should bring up the search box if it's in the overflow panel post-photon

Updated

a month ago
Flags: qe-verify?
Priority: -- → P2

Updated

a month ago
Flags: qe-verify? → qe-verify+
QA Contact: gwimberly
(Assignee)

Updated

22 days ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.4 - Aug 1
Priority: P2 → P1
Comment hidden (mozreview-request)

Comment 4

21 days ago
mozreview-review
Comment on attachment 8890849 [details]
Bug 1378807 - make search bar shortcut work in the permanent overflow panel,

https://reviewboard.mozilla.org/r/162074/#review167498

Looks good to me.  Tested on Windows with the searchbar pinned to the panel, overflowed to the panel, not anywhere, in the toolbar, and even in the tabstrip!

Thanks!  :D
Attachment #8890849 - Flags: review?(bwinton) → review+

Comment 5

21 days ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/87bd87bb4064
make search bar shortcut work in the permanent overflow panel, r=bwinton

Comment 6

21 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/87bd87bb4064
Status: ASSIGNED → RESOLVED
Last Resolved: 21 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
status-firefox54: --- → unaffected
status-firefox55: --- → unaffected
status-firefox-esr52: --- → unaffected
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.