|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
I used to have the search box in the hamburger menu. I was able to use Ctrl-K to pop open the menu, enter my search in the search box, hit enter, and have the search open in a new tab. At some point the search box disappeared from the hamburger menu, and Ctrl-K now focuses on the address bar. I can re-add the search box to the overflow panel using the menu customization tool. However, Ctrl-K does not open the overflow panel.
This is effectively a regression, so I think we just need to make sure we fix it given people do this, especially given the plans to remove the search bar from the default nav-bar configuration.
bug 1354117 covers moving added items from the hamburger panel into the overflow panel (and vice versa if you flip the pref). I'll morph this bug to explicitly be about the shortcut.
Comment on attachment 8890849 [details] Bug 1378807 - make search bar shortcut work in the permanent overflow panel, https://reviewboard.mozilla.org/r/162074/#review167498 Looks good to me. Tested on Windows with the searchbar pinned to the panel, overflowed to the panel, not anywhere, in the toolbar, and even in the tabstrip! Thanks! :D
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/87bd87bb4064 make search bar shortcut work in the permanent overflow panel, r=bwinton
Verified on Windows, Mac, and Ubuntu.