Stop using sdk/lang/functional in DevTools

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Developer Tools
P1
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: zer0, Assigned: sole)

Tracking

unspecified
Firefox 56
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [nosdk])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
Used in:

devtools/client/memory/components/tree-map/canvas-utils.js
devtools/client/memory/components/tree-map/drag-zoom.js
devtools/client/webaudioeditor/views/context.js

Updated

9 months ago
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
(Assignee)

Updated

9 months ago
Assignee: nobody → sole

Updated

9 months ago
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: --- → Firefox 56
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8888385 [details]
Bug 1378817 - Stop using sdk/lang/functional in DevTools.

https://reviewboard.mozilla.org/r/159332/#review164892

Nice! For the record the inspector defines its own debounce helper in devtools/client/inspector/shared/utils.
Maybe log a followup to reuse your new utils in the inspector

::: devtools/shared/debounce.js:40
(Diff revision 1)
> +    }
> +
> +    return result;
> +  };
> +};
> +

nit: two blank lines at the end of the file, should be only one.
Attachment #8888385 - Flags: review?(jdescottes) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

9 months ago
mozreview-review
Comment on attachment 8888385 [details]
Bug 1378817 - Stop using sdk/lang/functional in DevTools.

https://reviewboard.mozilla.org/r/159332/#review165060

::: devtools/shared/debounce.js:40
(Diff revision 1)
> +    }
> +
> +    return result;
> +  };
> +};
> +

fixed in a new commit!
Attachment #8888385 - Flags: review+
(Assignee)

Updated

9 months ago
Keywords: checkin-needed

Comment 5

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8baab0d7ec03
Stop using sdk/lang/functional in DevTools. r=jdescottes
Keywords: checkin-needed

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8baab0d7ec03
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Depends on: 1385157
No longer depends on: 1385157
You need to log in before you can comment on or make changes to this bug.