Status

Chat Core
Matrix
a year ago
10 months ago

People

(Reporter: matrixisreal, Assigned: matrixisreal)

Tracking

(Depends on: 1 bug)

trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Updated

a year ago
Assignee: nobody → pavankarthikboddeda
(Assignee)

Comment 1

a year ago
Created attachment 8883973 [details] [diff] [review]
tooltip.patch

Turns out, there is much less showable info compared to IRc.

Currently, just 3 items:
Display NAme,
Presence Status Message
Last Activity
Flags: needinfo?(fred.wang)
Flags: needinfo?(clokep)
Attachment #8883973 - Flags: review?
Attachment #8883973 - Flags: feedback+
Comment on attachment 8883973 [details] [diff] [review]
tooltip.patch

Review of attachment 8883973 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a good start! We should probably also show the level? That seems to be included in riot.im.

::: chat/locales/en-US/matrix.properties
@@ +21,5 @@
> +#    from the "User" object of that user.
> +#    The human readable name of the user.
> +tooltip.displayName= Display name
> +tooltip.presenceStatusMsg= Status message
> +tooltip.lastActiveAgo= Last activity

Please remove the space before all of these.

::: chat/protocols/matrix/matrix.js
@@ +5,5 @@
>  var {classes: Cc, interfaces: Ci, results: Cr, utils: Cu} = Components;
>  
>  Cu.import("resource:///modules/imXPCOMUtils.jsm");
>  Cu.import("resource:///modules/jsProtoHelper.jsm");
> +Cu.import("resource:///modules/imServices.jsm");

Please keep these in alphabetical order!

@@ +248,5 @@
> +      return EmptyEnumerator;
> +
> +    // Convert timespan in milli-seconds into a human-readable form.
> +    let getNormalizedTime = function(aTime) {
> +      let valuesAndUnits = DownloadUtils.convertTimeUnits(aTime/1000);

Nit: spaces on either side of /.

@@ +261,5 @@
> +
> +    if (user.displayName)
> +      tooltipInfo.push(new TooltipInfo(_("tooltip.displayName"), user.displayName));
> +
> +    // We probably need to set this as Away Message?

This needs to be set the status properly: https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#1247-1260

Is this actually just a message? Is there a concept of away vs. idle?
Attachment #8883973 - Flags: review?
Attachment #8883973 - Flags: review-
Attachment #8883973 - Flags: feedback+
Flags: needinfo?(clokep)

Updated

11 months ago
Flags: needinfo?(fred.wang)
(Assignee)

Updated

10 months ago
Depends on: 1394397
You need to log in before you can comment on or make changes to this bug.