1378832 - Stop using SDK in WebIDE

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, enhancement, P1)

Description

[Matteo Ferretti [:zer0] [:matteo]]

SDK modules used in WebIDE:

  sdk/system/child_process/subprocess
  sdk/system/environment
  sdk/system/runtime

Comment 1

[Kuba Niewiarowski]

Shouldn't it be resolved invalid due to Bug 1314811?

Comment 2

[Patrick Brosset <:pbro>]

(In reply to Kuba Niewiarowski from comment #1)
> Shouldn't it be resolved invalid due to Bug 1314811?
Removing the WebIDE entirely is a bigger project than what we can take on now, and we need to migrate away from the add-on SDK quickly. So this bug still makes sense.

Comment 3

[Alexandre Poirot [:ochameau]]

Regarding
http://searchfox.org/mozilla-central/source/devtools/client/webide/modules/build.js#9
I imagine we could remove this feature as it was really specific to apps and quite cryptic.

And for
http://searchfox.org/mozilla-central/source/devtools/client/webide/modules/simulator-process.js#12
We may use Subprocess.jsm, like the browser toolbox
http://searchfox.org/mozilla-central/source/devtools/client/framework/ToolboxProcess.jsm#17
Running simulators still work! and you can still debug all apps. This demonstrates that tool clients work still great on old actors.
We may also remove if that's easier as this is really specific to Firefox OS. But that may end up removing a lot of features, not necessarely well contained.

Comment 4

[Alexandre Poirot [:ochameau]]

Oh sorry, I missed https://bugzilla.mozilla.org/show_bug.cgi?id=1353656#c4

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Is that everything we need to remove here?

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> Is that everything we need to remove here?

I think so, fwd ni? to Matteo since Patrick is on PTO for 2 more weeks.
There are no references to the SDK left in devtools/client/webide.

Comment 7

[Alexandre Poirot [:ochameau]]

Yes, we are good for WebIDE.