Closed Bug 1378839 Opened 2 years ago Closed 2 years ago

Simplify GenerateLcovInfo code

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: marco, Assigned: marco)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
By adding the name parameter to collectCodeCoverageInfo, we can stop adding entries to the ScriptNameMap in GenerateLcovInfo just to remove them again right away.
Attachment #8883984 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8883984 [details] [diff] [review]
Patch

Review of attachment 8883984 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8883984 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/95c3747c49d1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → mcastelluccio
You need to log in before you can comment on or make changes to this bug.