1378846 - Stylo: http://www.twcc.com/select-provider#/ doesn't render properly

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Ludovic Hirlimann [:Usul]]

Attachment: Screenshot-2017-7-6 Select Provider.png

see attached screen shot.

Setting the pref to off and reloading the page fixes the issue.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Investigating...

This seems to be a case from different selector parsing.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Attachment: simplified testcase

The website is using a specific selector to do browser-sniff. This case it is the -moz-tree-row pseudo-class, which is part of thing tracked in bug 1348488.

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

This is problematic, though, because :-moz-tree-row is a non-standard internal selector. I believe we want to unship it from being accessed from web content at some point.

It is probably worth understanding why this website needs this trick.

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Another approach ahead is to unship :-moz-tree pseudos from web content, so that this website becomes broken in Firefox without Gecko (and thus not a regression from stylo). That can be done via bug 1379031.

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #4)
> Another approach ahead is to unship :-moz-tree pseudos from web content, so
> that this website becomes broken in Firefox without Gecko (and thus not a
> regression from stylo). That can be done via bug 1379031.

I meant... without Stylo...

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

AFAICS, this issue would be fixed with my patches in bug 1348488.

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

This should now be fixed. Please confirm with the next nightly.

Comment 8

[Darkspirit]

Verified fixed in Nightly 56 x64 20170713100259 @ Debian Testing (Linux 4.11.0-1-amd64, Radeon RX480).