Closed
Bug 1378884
Opened 8 years ago
Closed 8 years ago
upgrade all dependencies (except sqlalchemy)
Categories
(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P2)
Release Engineering Graveyard
Applications: Balrog (backend)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
Balrog dependencies on numerous Python libraries, many of which are now sorely out of date in requirements.txt. It should be easy to update the vast majority of them. I let pyup do this for me in a test repo (https://github.com/testbhearsum/balrog/pull/3), and things went mostly well. There were 8 test failures that looked like this:
auslib/web/admin/views/rules.py:107: in get
headers.update(get_csrf_headers())
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
def get_csrf_headers():
# Instantiating a Form makes sure there's a CSRF token available
# and puts an hmac key in the session.
form = Form()
> return {'X-CSRF-Token': form.csrf_token._value()}
E AttributeError: 'Form' object has no attribute 'csrf_token'
...but that was it. Manual testing will be needed as well before we can confidently merge the upgrades.
Upgrading sqlalchemy will be a much larger task, and already tracked in bug 1303424.
| Assignee | ||
Comment 1•8 years ago
|
||
I've been looking at getting pyup going for Balrog so I took a crack at this. After adding a bit of pyup metadata to the repo, it was pretty easy to upgrade most of the packages. More details in the PR.
Comment 2•8 years ago
|
||
Comment on attachment 8886332 [details] [review]
upgrade most of the things
Great!
Attachment #8886332 -
Flags: review?(jlorenzo) → review+
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog
https://github.com/mozilla/balrog/commit/6a864fdbbbc97bd018e393e9c8f7e6bf4497d91e
bug 1378884 (#352): upgrade all of the packages except sqlalchemy and sqlalchemy-migrate. r=jlorenzo
| Assignee | ||
Comment 4•8 years ago
|
||
This is in production.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•