Status

()

P3
normal
a year ago
a year ago

People

(Reporter: jya, Assigned: kaku)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox57 fix-optional)

Details

(Whiteboard: [gfx-noted])

(Reporter)

Description

a year ago
In bug 1141979, a NVImage type was added.

However, this image type incorrectly assume that the different plane strides are equal to the width.

This is rarely the case, especially with odd width image:

When calculating the size:
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/ImageContainer.cpp#666

when creating the image:
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/ImageContainer.cpp#671

Additionally, this code will leak should any dimensions be invalid, or any error conditions be triggered during the call to GetAsSourceSurface()

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/ImageContainer.cpp#668

Updated

a year ago
Whiteboard: [gfx-noted]
Assignee: nobody → kaku
status-firefox57: --- → fix-optional
You need to log in before you can comment on or make changes to this bug.